| 1 |
> On 22 Jul 2021, at 09:32, Patrice Clement <monsieurp@g.o> wrote: |
| 2 |
> |
| 3 |
> Thursday 22 Jul 2021 04:44:39, Sam James wrote : |
| 4 |
>> |
| 5 |
>>> [snip] |
| 6 |
>> |
| 7 |
>> The patch itself seems fine, but I have some suggestions while we're |
| 8 |
>> working on the eclass: |
| 9 |
>> |
| 10 |
>> [snip] |
| 11 |
|
| 12 |
>> Let me know if you need any assistance, etc. |
| 13 |
>> |
| 14 |
>> thanks, |
| 15 |
>> sam |
| 16 |
>> |
| 17 |
|
| 18 |
> Thanks for the suggestions. If you don't mind, I'd like to stick to the |
| 19 |
> original changes for now and address your suggestions later in a follow up |
| 20 |
> patch. |
| 21 |
|
| 22 |
It's preferred [0] where, if we know more changes are coming, to batch them up, |
| 23 |
unless this is really critical. This is because of needless cache regeneration. |
| 24 |
|
| 25 |
It's generally not a reason to block fixing something if no other issues exist, but it |
| 26 |
is a reason to stop and pause/reflect if there are any other low-hanging fruit we could fix while there. |
| 27 |
|
| 28 |
A lot of this is straightforward tidying. I don't mind if you're sure you will be able to return |
| 29 |
to it shortly, but then I figure, why not just do it now? |
| 30 |
|
| 31 |
[0] https://devmanual.gentoo.org/eclass-writing/index.html#adding-and-updating-eclasses (see the "Note") |
| 32 |
|
| 33 |
thanks, |
| 34 |
sam |
Archives