1 |
Thursday 22 Jul 2021 04:44:39, Sam James wrote : |
2 |
> |
3 |
> |
4 |
> > On 21 Jul 2021, at 17:47, Patrice Clement <monsieurp@g.o> wrote: |
5 |
> > |
6 |
> > ... and replace it with a test against the REPLACING_VERSIONS variable. |
7 |
> > |
8 |
> > See https://projects.gentoo.org/pms/8/pms.html#x1-10900011.1. |
9 |
> > |
10 |
> > Patch courtesy of Arfrever. |
11 |
> > |
12 |
> |
13 |
> Ideally, we'd use Arfrever's sign off, but this is kind of a grey |
14 |
> area, so it's not a blocker at all right now. |
15 |
> |
16 |
> > Closes: https://github.com/gentoo/gentoo/pull/21733 |
17 |
> > Signed-off-by: Patrice Clement <monsieurp@g.o> |
18 |
> > --- |
19 |
> > eclass/vim-plugin.eclass | 12 ++++++------ |
20 |
> > 1 file changed, 6 insertions(+), 6 deletions(-) |
21 |
> > |
22 |
> > diff --git a/eclass/vim-plugin.eclass b/eclass/vim-plugin.eclass |
23 |
> > index 6b72d66111d..460edcce3eb 100644 |
24 |
> > --- a/eclass/vim-plugin.eclass |
25 |
> > +++ b/eclass/vim-plugin.eclass |
26 |
> > [snip] |
27 |
> |
28 |
> The patch itself seems fine, but I have some suggestions while we're |
29 |
> working on the eclass: |
30 |
> |
31 |
> - Add EAPI 8 support |
32 |
> |
33 |
> - Please drop obsolete EAPI compatibility hacks like: |
34 |
> >has "${EAPI:-0}" 0 1 2 && ! use prefix && ED="${D}" |
35 |
> |
36 |
> This is unnecessary because we're only declaring support for EAPI 6 and 7 right now. |
37 |
> |
38 |
> - Could you please convert POSIX tests to Bash tests? [0] |
39 |
> |
40 |
> - In update_vim_afterscripts, the einfo seems (at first glance) to be misleading. Should |
41 |
> it be printing ${afterdir} instead? |
42 |
> |
43 |
> - Ideally, we'd add the standard inherit guard if possible (see e.g. gnuconfig.eclass for a simple example). |
44 |
> |
45 |
> [0] https://devmanual.gentoo.org/tools-reference/bash/#single-versus-double-brackets-in-bash |
46 |
> |
47 |
> Let me know if you need any assistance, etc. |
48 |
> |
49 |
> thanks, |
50 |
> sam |
51 |
> |
52 |
> |
53 |
> |
54 |
> |
55 |
|
56 |
Thanks for the suggestions. If you don't mind, I'd like to stick to the |
57 |
original changes for now and address your suggestions later in a follow up |
58 |
patch. |
59 |
|
60 |
Best, |