| 1 |
On Tue, 29 Nov 2016 09:46:18 +0100 |
| 2 |
Michał Górny <mgorny@g.o> wrote: |
| 3 |
|
| 4 |
> On Mon, 28 Nov 2016 06:42:44 -0500 |
| 5 |
> Mike Pagano <mpagano@g.o> wrote: |
| 6 |
> |
| 7 |
> > On 11/27/2016 09:06 PM, Mike Gilbert wrote: |
| 8 |
> > > On Sun, Nov 27, 2016 at 7:23 PM, Mike Pagano <mpagano@g.o> wrote: |
| 9 |
> > >> If kernel-2_src_unpack() is called in EAPI6, epatch_user() function |
| 10 |
> > >> inherited from eutils.eclass is undefined. |
| 11 |
> > >> See bug #579188 |
| 12 |
> > > |
| 13 |
> > > kernel-2.eclass currently calls die in global scope for EAPI 6, so |
| 14 |
> > > this change has no real effect. |
| 15 |
> > > |
| 16 |
> > > I would suggest modernizing the eclass before allowing it to be used |
| 17 |
> > > with EAPI 6. For example, patches should be applied in src_prepare, |
| 18 |
> > > not src_unpack. |
| 19 |
> > > |
| 20 |
> > |
| 21 |
> > Is this change not a step in the right direction? Or should it just be |
| 22 |
> > one big bang? |
| 23 |
> > All or nothing? |
| 24 |
> |
| 25 |
> While I don't mean incremental changes, I'd really prefer if they made |
| 26 |
|
| 27 |
s/mean/mind/. |
| 28 |
|
| 29 |
|
| 30 |
-- |
| 31 |
Best regards, |
| 32 |
Michał Górny |
| 33 |
<http://dev.gentoo.org/~mgorny/> |
Archives