| 1 |
On Mon, 28 Nov 2016 06:42:44 -0500 |
| 2 |
Mike Pagano <mpagano@g.o> wrote: |
| 3 |
|
| 4 |
> On 11/27/2016 09:06 PM, Mike Gilbert wrote: |
| 5 |
> > On Sun, Nov 27, 2016 at 7:23 PM, Mike Pagano <mpagano@g.o> wrote: |
| 6 |
> >> If kernel-2_src_unpack() is called in EAPI6, epatch_user() function |
| 7 |
> >> inherited from eutils.eclass is undefined. |
| 8 |
> >> See bug #579188 |
| 9 |
> > |
| 10 |
> > kernel-2.eclass currently calls die in global scope for EAPI 6, so |
| 11 |
> > this change has no real effect. |
| 12 |
> > |
| 13 |
> > I would suggest modernizing the eclass before allowing it to be used |
| 14 |
> > with EAPI 6. For example, patches should be applied in src_prepare, |
| 15 |
> > not src_unpack. |
| 16 |
> > |
| 17 |
> |
| 18 |
> Is this change not a step in the right direction? Or should it just be |
| 19 |
> one big bang? |
| 20 |
> All or nothing? |
| 21 |
|
| 22 |
While I don't mean incremental changes, I'd really prefer if they made |
| 23 |
any sense. Calling eapply_user in src_unpack() is invalid, per PMS: |
| 24 |
|
| 25 |
| In EAPIs where it is supported, eapply_user must be called once |
| 26 |
| in the src_prepare phase. |
| 27 |
|
| 28 |
-- |
| 29 |
Best regards, |
| 30 |
Michał Górny |
| 31 |
<http://dev.gentoo.org/~mgorny/> |
Archives