| 1 |
Petteri Räty wrote: |
| 2 |
> Steev Klimaszewski kirjoitti: |
| 3 |
>> Vlastimil Babka wrote: |
| 4 |
>> |
| 5 |
>>> dodoc calls should have || die and USE=doc should be tested before |
| 6 |
>>> commiting a bump, IMHO |
| 7 |
>>> |
| 8 |
>> Sorry, I didn't realize my 3 hour compile of $APPLICATION should die |
| 9 |
>> because TODO wasn't around. Vote against || die - it doesn't affect |
| 10 |
>> anything aside from misc docs not being installed, if its really that |
| 11 |
>> important, most people hit the website anyway. (But yes, they should be |
| 12 |
>> corrected and tested before committing) |
| 13 |
>> |
| 14 |
> |
| 15 |
> And is the average ebuild 3 hours and haven't you heard about FEATURES |
| 16 |
> noauto? The || die is there for maintainers to spot when version |
| 17 |
> bumping. If you commit a version that's broken with missing TODO and || |
| 18 |
> die you should think about if you are doing everything right... |
| 19 |
> |
| 20 |
|
| 21 |
Just thinking aloud - why not add some (QA?) notice in the summary when |
| 22 |
dodoc (and possibly other do*'s) fails? One would be instructed to file |
| 23 |
a new bug when he sees it *and*, after all, the package will have still |
| 24 |
been merged successfuly. |
| 25 |
|
| 26 |
Best regards, |
| 27 |
Jurek Bartuszek |
| 28 |
-- |
| 29 |
gentoo-dev@g.o mailing list |
Archives