Archives
Archives
| From: | "Chí-Thanh Christopher Nguyễn" <chithanh@g.o> | ||
|---|---|---|---|
| To: | gentoo-dev@l.g.o | ||
| Subject: | Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts | ||
| Date: | Sun, 24 Jul 2016 08:17:41 | ||
| Message-Id: | 57947994.9030000@gentoo.org | ||
| In Reply to: | Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts by "Michał Górny" |
||
| 1 | Michał Górny schrieb: |
| 2 | > So, to summarize we shouldn't fix existing code because people did |
| 3 | > assume accepting invalid parameters was fine. |
| 4 | |
| 5 | You are changing the API of versionator.eclass, even if it was unintentional API. |
| 6 | |
| 7 | > Then ebuilds will fail just the same |
| 8 | |
| 9 | No. Before, ebuilds would maybe display an upgrading message when they |
| 10 | shouldn't, or vice versa. Now the eclass dies on them. |
| 11 | |
| 12 | |
| 13 | Best regards, |
| 14 | Chí-Thanh Christopher Nguyễn |
| Subject | Author |
|---|---|
| Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts | Ciaran McCreesh <ciaran.mccreesh@××××××××××.com> |
| Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts | Jason Zaman <perfinion@g.o> |
| Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts | "Michał Górny" <mgorny@g.o> |
| Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts | Alexis Ballier <aballier@g.o> |