Gentoo Archives: gentoo-dev

From: Jason Zaman <perfinion@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts
Date: Sun, 24 Jul 2016 09:41:57
Message-Id: 20160724094135.GA18565@meriadoc
In Reply to: Re: [gentoo-dev] [PATCH] versionator.eclass: Add tests for parameter counts by "Chí-Thanh Christopher Nguyễn"
1 On Sun, Jul 24, 2016 at 10:17:24AM +0200, Chí-Thanh Christopher Nguyễn wrote:
2 > Michał Górny schrieb:
3 > > So, to summarize we shouldn't fix existing code because people did
4 > > assume accepting invalid parameters was fine.
5 >
6 > You are changing the API of versionator.eclass, even if it was unintentional API.
7
8 # @FUNCTION: version_is_at_least
9 # @USAGE: <want> [have]
10 # @DESCRIPTION:
11 # Is $2 (defaults to $PVR) at least version $1? Intended for use in eclasses
12 # only. May not be reliable, be sure to do very careful testing before actually
13 # using this.
14
15 The API seems pretty clear to me ...
16
17 -- Jason