Gentoo Archives: gentoo-dev

From: Ian Stakenvicius <axs@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH python-r1 5/8] Convert x11-misc/redshift to python-r1 (example).
Date: Mon, 29 Oct 2012 15:26:26
Message-Id: 508E9FED.6000905@gentoo.org
In Reply to: [gentoo-dev] [PATCH python-r1 5/8] Convert x11-misc/redshift to python-r1 (example). by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 27/10/12 07:02 AM, Micha? Górny wrote:
5 > This serves as an example how the new functions can be used. ---
6 > gx86/x11-misc/redshift/redshift-1.7-r1.ebuild | 33
7 > ++++++++++++--------------- 1 file changed, 14 insertions(+), 19
8 > deletions(-)
9 >
10 > diff --git a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild
11 > b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild index
12 > f3bd210..589e571 100644 ---
13 > a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild +++
14 > b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild @@ -24,7 +21,8 @@
15 > COMMON_DEPEND=">=x11-libs/libX11-1.4 x11-libs/libxcb geoclue? (
16 > app-misc/geoclue ) gnome? ( dev-libs/glib:2 - >=gnome-base/gconf-2
17 > )" + >=gnome-base/gconf-2 ) + gtk? ( ${PYTHON_DEPS} )"
18 > RDEPEND="${COMMON_DEPEND} gtk? ( >=dev-python/pygtk-2
19 > dev-python/pyxdg )"
20
21
22 ..should we not also ensure that the PYTHON_TARGETS for pygtk-2 and
23 pyxdg match (or at least include) the PYTHON_TARGETS being used for
24 this package? IE:
25
26 > RDEPEND="${COMMON_DEPEND} - gtk? ( >=dev-python/pygtk-2 -
27 > dev-python/pyxdg )" + gtk? ( >=dev-python/pygtk-2[$PYTHON_USEDEP]
28 > + dev-python/pyxdg[$PYTHON_USEDEP] )"
29
30
31 I don't know if this is actually needed by the package but I would
32 assume so as it seems to be building and installing for multiple pythons..
33 -----BEGIN PGP SIGNATURE-----
34 Version: GnuPG v2.0.19 (GNU/Linux)
35
36 iF4EAREIAAYFAlCOn+wACgkQ2ugaI38ACPBumgD9FDoSOvYTftLxQuo6Hix6ud9l
37 eZ0f5iLnD2SfzaaWcxwA/022wryA/f+f0ebg9WmS+C4AuzNvCQMQe7El3ERuAw23
38 =KDxM
39 -----END PGP SIGNATURE-----

Replies