Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: axs@g.o
Subject: Re: [gentoo-dev] [PATCH python-r1 5/8] Convert x11-misc/redshift to python-r1 (example).
Date: Mon, 29 Oct 2012 15:42:45
Message-Id: 20121029164254.00899b48@pomiocik.lan
In Reply to: Re: [gentoo-dev] [PATCH python-r1 5/8] Convert x11-misc/redshift to python-r1 (example). by Ian Stakenvicius
1 On Mon, 29 Oct 2012 11:25:33 -0400
2 Ian Stakenvicius <axs@g.o> wrote:
3
4 > -----BEGIN PGP SIGNED MESSAGE-----
5 > Hash: SHA256
6 >
7 > On 27/10/12 07:02 AM, Micha? Górny wrote:
8 > > This serves as an example how the new functions can be used. ---
9 > > gx86/x11-misc/redshift/redshift-1.7-r1.ebuild | 33
10 > > ++++++++++++--------------- 1 file changed, 14 insertions(+), 19
11 > > deletions(-)
12 > >
13 > > diff --git a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild
14 > > b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild index
15 > > f3bd210..589e571 100644 ---
16 > > a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild +++
17 > > b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild @@ -24,7 +21,8 @@
18 > > COMMON_DEPEND=">=x11-libs/libX11-1.4 x11-libs/libxcb geoclue? (
19 > > app-misc/geoclue ) gnome? ( dev-libs/glib:2 - >=gnome-base/gconf-2
20 > > )" + >=gnome-base/gconf-2 ) + gtk? ( ${PYTHON_DEPS} )"
21 > > RDEPEND="${COMMON_DEPEND} gtk? ( >=dev-python/pygtk-2
22 > > dev-python/pyxdg )"
23 >
24 >
25 > ..should we not also ensure that the PYTHON_TARGETS for pygtk-2 and
26 > pyxdg match (or at least include) the PYTHON_TARGETS being used for
27 > this package? IE:
28 >
29 > > RDEPEND="${COMMON_DEPEND} - gtk? ( >=dev-python/pygtk-2 -
30 > > dev-python/pyxdg )" + gtk? ( >=dev-python/pygtk-2[$PYTHON_USEDEP]
31 > > + dev-python/pyxdg[$PYTHON_USEDEP] )"
32 >
33 >
34 > I don't know if this is actually needed by the package but I would
35 > assume so as it seems to be building and installing for multiple pythons..
36
37 Yes, of course that'd need to be done if and when pygtk and pyxdg start
38 using PYTHON_TARGETS ;).
39
40 --
41 Best regards,
42 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies