Gentoo Archives: gentoo-dev

From: Ian Stakenvicius <axs@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH python-r1 5/8] Convert x11-misc/redshift to python-r1 (example).
Date: Mon, 29 Oct 2012 15:48:18
Message-Id: 508EA518.9060705@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH python-r1 5/8] Convert x11-misc/redshift to python-r1 (example). by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 29/10/12 11:42 AM, Michał Górny wrote:
5 > On Mon, 29 Oct 2012 11:25:33 -0400 Ian Stakenvicius
6 > <axs@g.o> wrote:
7 >
8 >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
9 >>
10 >> On 27/10/12 07:02 AM, Micha? Górny wrote:
11 >>> This serves as an example how the new functions can be used.
12 >>> --- gx86/x11-misc/redshift/redshift-1.7-r1.ebuild | 33
13 >>> ++++++++++++--------------- 1 file changed, 14 insertions(+),
14 >>> 19 deletions(-)
15 >>>
16 >>> diff --git a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild
17 >>> b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild index
18 >>> f3bd210..589e571 100644 ---
19 >>> a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild +++
20 >>> b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild @@ -24,7 +21,8
21 >>> @@ COMMON_DEPEND=">=x11-libs/libX11-1.4 x11-libs/libxcb
22 >>> geoclue? ( app-misc/geoclue ) gnome? ( dev-libs/glib:2 -
23 >>> >=gnome-base/gconf-2 )" + >=gnome-base/gconf-2 ) + gtk? (
24 >>> ${PYTHON_DEPS} )" RDEPEND="${COMMON_DEPEND} gtk? (
25 >>> >=dev-python/pygtk-2 dev-python/pyxdg )"
26 >>
27 >>
28 >> ..should we not also ensure that the PYTHON_TARGETS for pygtk-2
29 >> and pyxdg match (or at least include) the PYTHON_TARGETS being
30 >> used for this package? IE:
31 >>
32 >>> RDEPEND="${COMMON_DEPEND} - gtk? ( >=dev-python/pygtk-2 -
33 >>> dev-python/pyxdg )" + gtk? (
34 >>> >=dev-python/pygtk-2[$PYTHON_USEDEP] +
35 >>> dev-python/pyxdg[$PYTHON_USEDEP] )"
36 >>
37 >>
38 >> I don't know if this is actually needed by the package but I
39 >> would assume so as it seems to be building and installing for
40 >> multiple pythons..
41 >
42 > Yes, of course that'd need to be done if and when pygtk and pyxdg
43 > start using PYTHON_TARGETS ;).
44 >
45
46 I guess it wouldn't work to make $PYTHON_USEDEP contain
47 "python_target_whatever(+)" strings so that the targets being missing
48 would still allow the use deps to exist, huh...
49
50 I'm thinking this wouldn't catch issues where the PYTHON_COMPAT of a
51 dep is not as complete as the PYTHON_COMPAT of the consumer (and i
52 assume we would want to error on that)
53
54 -----BEGIN PGP SIGNATURE-----
55 Version: GnuPG v2.0.19 (GNU/Linux)
56
57 iF4EAREIAAYFAlCOpRgACgkQ2ugaI38ACPBsaAD/R6Sqq2VGcmmUg6hqyWsWUG4v
58 aiV1vKdLGj+rpayOX8MA/A5iNmR0DYQ/ebTiQ+lzXqjbEmoc9o6yUxPbJ2OgeR66
59 =wtJu
60 -----END PGP SIGNATURE-----

Replies