1 |
On Mon, 29 Oct 2012 11:47:36 -0400 |
2 |
Ian Stakenvicius <axs@g.o> wrote: |
3 |
|
4 |
> -----BEGIN PGP SIGNED MESSAGE----- |
5 |
> Hash: SHA256 |
6 |
> |
7 |
> On 29/10/12 11:42 AM, Michał Górny wrote: |
8 |
> > On Mon, 29 Oct 2012 11:25:33 -0400 Ian Stakenvicius |
9 |
> > <axs@g.o> wrote: |
10 |
> > |
11 |
> >> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 |
12 |
> >> |
13 |
> >> On 27/10/12 07:02 AM, Micha? Górny wrote: |
14 |
> >>> This serves as an example how the new functions can be used. |
15 |
> >>> --- gx86/x11-misc/redshift/redshift-1.7-r1.ebuild | 33 |
16 |
> >>> ++++++++++++--------------- 1 file changed, 14 insertions(+), |
17 |
> >>> 19 deletions(-) |
18 |
> >>> |
19 |
> >>> diff --git a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild |
20 |
> >>> b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild index |
21 |
> >>> f3bd210..589e571 100644 --- |
22 |
> >>> a/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild +++ |
23 |
> >>> b/gx86/x11-misc/redshift/redshift-1.7-r1.ebuild @@ -24,7 +21,8 |
24 |
> >>> @@ COMMON_DEPEND=">=x11-libs/libX11-1.4 x11-libs/libxcb |
25 |
> >>> geoclue? ( app-misc/geoclue ) gnome? ( dev-libs/glib:2 - |
26 |
> >>> >=gnome-base/gconf-2 )" + >=gnome-base/gconf-2 ) + gtk? ( |
27 |
> >>> ${PYTHON_DEPS} )" RDEPEND="${COMMON_DEPEND} gtk? ( |
28 |
> >>> >=dev-python/pygtk-2 dev-python/pyxdg )" |
29 |
> >> |
30 |
> >> |
31 |
> >> ..should we not also ensure that the PYTHON_TARGETS for pygtk-2 |
32 |
> >> and pyxdg match (or at least include) the PYTHON_TARGETS being |
33 |
> >> used for this package? IE: |
34 |
> >> |
35 |
> >>> RDEPEND="${COMMON_DEPEND} - gtk? ( >=dev-python/pygtk-2 - |
36 |
> >>> dev-python/pyxdg )" + gtk? ( |
37 |
> >>> >=dev-python/pygtk-2[$PYTHON_USEDEP] + |
38 |
> >>> dev-python/pyxdg[$PYTHON_USEDEP] )" |
39 |
> >> |
40 |
> >> |
41 |
> >> I don't know if this is actually needed by the package but I |
42 |
> >> would assume so as it seems to be building and installing for |
43 |
> >> multiple pythons.. |
44 |
> > |
45 |
> > Yes, of course that'd need to be done if and when pygtk and pyxdg |
46 |
> > start using PYTHON_TARGETS ;). |
47 |
> > |
48 |
> |
49 |
> I guess it wouldn't work to make $PYTHON_USEDEP contain |
50 |
> "python_target_whatever(+)" strings so that the targets being missing |
51 |
> would still allow the use deps to exist, huh... |
52 |
|
53 |
...that sounded like a good idea... |
54 |
|
55 |
> I'm thinking this wouldn't catch issues where the PYTHON_COMPAT of a |
56 |
> dep is not as complete as the PYTHON_COMPAT of the consumer (and i |
57 |
> assume we would want to error on that) |
58 |
|
59 |
...before this part ;). So I guess it's safer to just keep it like it |
60 |
is, and assume that when converting a package to p-r1, you are supposed |
61 |
to check its revdeps to add $PYTHON_USEDEP whenever necessary. |
62 |
|
63 |
-- |
64 |
Best regards, |
65 |
Michał Górny |