Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: pinkbyte@g.o
Subject: Re: [gentoo-dev] [RFC] SDL2 update
Date: Thu, 29 Aug 2013 06:46:01
Message-Id: 20130829084556.6edf2e14@gentoo.org
In Reply to: Re: [gentoo-dev] [RFC] SDL2 update by Sergey Popov
1 Dnia 2013-08-29, o godz. 10:41:08
2 Sergey Popov <pinkbyte@g.o> napisał(a):
3
4 > 28.08.2013 20:06, hasufell пишет:
5 > > On 08/28/2013 05:53 PM, "Paweł Hajdan, Jr." wrote:
6 > >>>
7 > >>> S=${WORKDIR}/SDL2_mixer-${PV}
8 > >
9 > >> Why no quotes? ("")
10 > >
11 > >
12 > >>> S=${WORKDIR}/${MY_P}
13 > >
14 > >> Why no quotes? ("")
15 > >
16 > >
17 > >>> S=${WORKDIR}/SDL2_ttf-${PV}
18 > >
19 > >> I suggest quotes ("").
20 > >
21 > >
22 > >
23 > > Those are variable assignments and don't need a quote.
24 > >
25 >
26 > And if WORKDIR will contain whitespace(s), does this code still be
27 > working? :-)
28
29 Yes.
30
31 --
32 Best regards,
33 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature