| 1 |
28.08.2013 20:06, hasufell пишет: |
| 2 |
> On 08/28/2013 05:53 PM, "Paweł Hajdan, Jr." wrote: |
| 3 |
>>> |
| 4 |
>>> S=${WORKDIR}/SDL2_mixer-${PV} |
| 5 |
> |
| 6 |
>> Why no quotes? ("") |
| 7 |
> |
| 8 |
> |
| 9 |
>>> S=${WORKDIR}/${MY_P} |
| 10 |
> |
| 11 |
>> Why no quotes? ("") |
| 12 |
> |
| 13 |
> |
| 14 |
>>> S=${WORKDIR}/SDL2_ttf-${PV} |
| 15 |
> |
| 16 |
>> I suggest quotes (""). |
| 17 |
> |
| 18 |
> |
| 19 |
> |
| 20 |
> Those are variable assignments and don't need a quote. |
| 21 |
> |
| 22 |
|
| 23 |
And if WORKDIR will contain whitespace(s), does this code still be |
| 24 |
working? :-) |
| 25 |
|
| 26 |
// sorry for bikeshedding, can not resist |
| 27 |
|
| 28 |
-- |
| 29 |
Best regards, Sergey Popov |
| 30 |
Gentoo developer |
| 31 |
Gentoo Desktop Effects project lead |
| 32 |
Gentoo Qt project lead |
| 33 |
Gentoo Proxy maintainers project lead |
Archives