| 1 |
On Thu, 23 Mar 2017 12:36:24 -0400 |
| 2 |
Michael Orlitzky <mjo@g.o> wrote: |
| 3 |
|
| 4 |
> On 03/23/2017 09:36 AM, Alexis Ballier wrote: |
| 5 |
> >> |
| 6 |
> >> No, the argument is about "we want to clean up the tree from |
| 7 |
> >> abusive hacks". |
| 8 |
> > |
| 9 |
> > This is yours. Mike's answer is merely asking for proper |
| 10 |
> > justification and doesn't seem to have had an answer yet. |
| 11 |
> > |
| 12 |
> |
| 13 |
> The PMS[0] says |
| 14 |
> |
| 15 |
> Ebuilds must not access [FILESDIR] in global scope. |
| 16 |
> |
| 17 |
> But, for example, autoconf-2.69-r2.ebuild does, |
| 18 |
> |
| 19 |
> if [[ -z ${__EBLITS__} && -n ${FILESDIR} ]] ; then |
| 20 |
> source "${FILESDIR}"/eblits/main.eblit || die |
| 21 |
> fi |
| 22 |
> |
| 23 |
> in global scope. |
| 24 |
> |
| 25 |
|
| 26 |
Continuing to be the devil's advocate, it seems adding '&& -d |
| 27 |
${FILESDIR}' to that if would fix the issue too. At least with all |
| 28 |
currently approved EAPIs. |
| 29 |
|
| 30 |
|
| 31 |
About the part you quote, please see: |
| 32 |
https://gitweb.gentoo.org/proj/pms.git/commit/?id=22a0ce7c0fe649572956f60d13e1003ced401689 |
| 33 |
|
| 34 |
This is arguably a backwards-breaking change in PMS that appeared after |
| 35 |
the last EAPI was approved, so I definitely understand the need for a |
| 36 |
better explanation here. Prior to that change, the only rule was that |
| 37 |
ebuilds must not assume the directory exists except in src_* phases. |
| 38 |
|
| 39 |
Alexis. |
Archives