Gentoo Archives: gentoo-dev

From: Michael Orlitzky <mjo@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [PATCH] sys-devel/autoconf: Convert from eblits into an eclass, #586424
Date: Thu, 23 Mar 2017 16:36:43
Message-Id: eada7195-7d24-2e33-8702-7ef4f679cd01@gentoo.org
In Reply to: Re: [gentoo-dev] Re: [PATCH] sys-devel/autoconf: Convert from eblits into an eclass, #586424 by Alexis Ballier
1 On 03/23/2017 09:36 AM, Alexis Ballier wrote:
2 >>
3 >> No, the argument is about "we want to clean up the tree from abusive
4 >> hacks".
5 >
6 > This is yours. Mike's answer is merely asking for proper justification
7 > and doesn't seem to have had an answer yet.
8 >
9
10 The PMS[0] says
11
12 Ebuilds must not access [FILESDIR] in global scope.
13
14 But, for example, autoconf-2.69-r2.ebuild does,
15
16 if [[ -z ${__EBLITS__} && -n ${FILESDIR} ]] ; then
17 source "${FILESDIR}"/eblits/main.eblit || die
18 fi
19
20 in global scope.
21
22 I think there are some related patches to block this sort of thing in
23 portage, but portage can't be improved while a critical package is doing
24 the thing that we want to prevent.
25
26
27 [0] https://dev.gentoo.org/~ulm/pms/head/pms.html#fn4x12

Replies