Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: Andrew Savchenko <bircoph@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] News Item: OpenAFS no longer needs kernel option DEBUG_RODATA
Date: Thu, 21 Jul 2016 05:12:38
Message-Id: 20160721071212.22b48f8a.mgorny@gentoo.org
In Reply to: Re: [gentoo-dev] News Item: OpenAFS no longer needs kernel option DEBUG_RODATA by Andrew Savchenko
1 On Thu, 21 Jul 2016 00:22:36 +0300
2 Andrew Savchenko <bircoph@g.o> wrote:
3
4 > On Wed, 20 Jul 2016 15:12:01 -0400 Michael Orlitzky wrote:
5 > > On 07/20/2016 01:13 PM, NP-Hardass wrote:
6 > > > Display-If-Installed: <=net-fs/openafs-kernel-1.6.18.2
7 > > >
8 > > > ...
9 > > >
10 > > > Starting with net-fs/openafs-kernel-1.6.18.2, this condition is no longer
11 > > > forced in the ebuild.
12 > >
13 > > Might not that version bound might backfire if someone upgrades before
14 > > reading the news? People who pull from git often don't necessarily get
15 > > the news in a timely fashion.
16 > >
17 > > Would it be simpler to ewarn in the ebuilds (for e.g. a year) if
18 > > DEBUG_RODATA=n?
19 >
20 > We already do this in openafs-kernel-1.6.18.2.ebuild:
21 >
22 > if use kernel_linux && [[ ${REPLACING_VERSIONS} < "1.6.18.2" ]]; then
23
24 Few important QA notes:
25
26 1. < is lexicographical comparison, so e.g. 1.6.2.2 < 1.6.18.2 gives
27 false,
28
29 2. REPLACING_VERSIONS can have more than one value,
30
31 3. Finally, '' < 1.6.18.2 gives true, so it is also printed for initial
32 install.
33
34 --
35 Best regards,
36 Michał Górny
37 <http://dev.gentoo.org/~mgorny/>

Replies