| 1 |
On Thu, 21 Jul 2016 07:12:12 +0200 Michał Górny wrote: |
| 2 |
> On Thu, 21 Jul 2016 00:22:36 +0300 |
| 3 |
> Andrew Savchenko <bircoph@g.o> wrote: |
| 4 |
> |
| 5 |
> > On Wed, 20 Jul 2016 15:12:01 -0400 Michael Orlitzky wrote: |
| 6 |
> > > On 07/20/2016 01:13 PM, NP-Hardass wrote: |
| 7 |
> > > > Display-If-Installed: <=net-fs/openafs-kernel-1.6.18.2 |
| 8 |
> > > > |
| 9 |
> > > > ... |
| 10 |
> > > > |
| 11 |
> > > > Starting with net-fs/openafs-kernel-1.6.18.2, this condition is no longer |
| 12 |
> > > > forced in the ebuild. |
| 13 |
> > > |
| 14 |
> > > Might not that version bound might backfire if someone upgrades before |
| 15 |
> > > reading the news? People who pull from git often don't necessarily get |
| 16 |
> > > the news in a timely fashion. |
| 17 |
> > > |
| 18 |
> > > Would it be simpler to ewarn in the ebuilds (for e.g. a year) if |
| 19 |
> > > DEBUG_RODATA=n? |
| 20 |
> > |
| 21 |
> > We already do this in openafs-kernel-1.6.18.2.ebuild: |
| 22 |
> > |
| 23 |
> > if use kernel_linux && [[ ${REPLACING_VERSIONS} < "1.6.18.2" ]]; then |
| 24 |
> |
| 25 |
> Few important QA notes: |
| 26 |
> |
| 27 |
> 1. < is lexicographical comparison, so e.g. 1.6.2.2 < 1.6.18.2 gives |
| 28 |
> false, |
| 29 |
|
| 30 |
Thanks, fixed. |
| 31 |
|
| 32 |
> 2. REPLACING_VERSIONS can have more than one value, |
| 33 |
|
| 34 |
While it can indeed, I see no way for this to happen if package |
| 35 |
hasn't and never had multiple slots. |
| 36 |
|
| 37 |
> 3. Finally, '' < 1.6.18.2 gives true, so it is also printed for initial |
| 38 |
> install. |
| 39 |
|
| 40 |
Fixed. |
| 41 |
|
| 42 |
Best regards, |
| 43 |
Andrew Savchenko |
Archives