| 1 |
Dnia 22 lipca 2016 13:00:42 CEST, Andrew Savchenko <bircoph@g.o> napisał(a): |
| 2 |
>On Thu, 21 Jul 2016 07:12:12 +0200 Michał Górny wrote: |
| 3 |
>> On Thu, 21 Jul 2016 00:22:36 +0300 |
| 4 |
>> Andrew Savchenko <bircoph@g.o> wrote: |
| 5 |
>> |
| 6 |
>> > On Wed, 20 Jul 2016 15:12:01 -0400 Michael Orlitzky wrote: |
| 7 |
>> > > On 07/20/2016 01:13 PM, NP-Hardass wrote: |
| 8 |
>> > > > Display-If-Installed: <=net-fs/openafs-kernel-1.6.18.2 |
| 9 |
>> > > > |
| 10 |
>> > > > ... |
| 11 |
>> > > > |
| 12 |
>> > > > Starting with net-fs/openafs-kernel-1.6.18.2, this condition is |
| 13 |
>no longer |
| 14 |
>> > > > forced in the ebuild. |
| 15 |
>> > > |
| 16 |
>> > > Might not that version bound might backfire if someone upgrades |
| 17 |
>before |
| 18 |
>> > > reading the news? People who pull from git often don't |
| 19 |
>necessarily get |
| 20 |
>> > > the news in a timely fashion. |
| 21 |
>> > > |
| 22 |
>> > > Would it be simpler to ewarn in the ebuilds (for e.g. a year) if |
| 23 |
>> > > DEBUG_RODATA=n? |
| 24 |
>> > |
| 25 |
>> > We already do this in openafs-kernel-1.6.18.2.ebuild: |
| 26 |
>> > |
| 27 |
>> > if use kernel_linux && [[ ${REPLACING_VERSIONS} < "1.6.18.2" |
| 28 |
>]]; then |
| 29 |
>> |
| 30 |
>> Few important QA notes: |
| 31 |
>> |
| 32 |
>> 1. < is lexicographical comparison, so e.g. 1.6.2.2 < 1.6.18.2 gives |
| 33 |
>> false, |
| 34 |
> |
| 35 |
>Thanks, fixed. |
| 36 |
> |
| 37 |
>> 2. REPLACING_VERSIONS can have more than one value, |
| 38 |
> |
| 39 |
>While it can indeed, I see no way for this to happen if package |
| 40 |
>hasn't and never had multiple slots. |
| 41 |
|
| 42 |
Wrong. PMS specifically requests you to account for such a possibility. |
| 43 |
|
| 44 |
> |
| 45 |
>> 3. Finally, '' < 1.6.18.2 gives true, so it is also printed for |
| 46 |
>initial |
| 47 |
>> install. |
| 48 |
> |
| 49 |
>Fixed. |
| 50 |
> |
| 51 |
>Best regards, |
| 52 |
>Andrew Savchenko |
| 53 |
|
| 54 |
|
| 55 |
-- |
| 56 |
Best regards, |
| 57 |
Michał Górny (by phone) |
Archives