Gentoo Archives: gentoo-dev

From: Matt Turner <mattst88@g.o>
To: gentoo development <gentoo-dev@l.g.o>
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-dev] [PATCH v2 2/3] distutils-r1.eclass: Use python_has_version in ...enable_sphinx
Date: Thu, 10 Feb 2022 23:28:15
Message-Id: CAEdQ38GUt-SYP9g+vpQXmhrceW=Er2HyXXJ+bnq1w-eexhxdaQ@mail.gmail.com
In Reply to: [gentoo-dev] [PATCH v2 2/3] distutils-r1.eclass: Use python_has_version in ...enable_sphinx by "Michał Górny"
1 On Thu, Feb 10, 2022 at 6:45 AM Michał Górny <mgorny@g.o> wrote:
2 >
3 > Signed-off-by: Michał Górny <mgorny@g.o>
4
5
6 Looks good to me. I noticed that this implementation takes only a
7 single -b/-d/-r as the initial argument and then a list of packages.
8 I'd suggested pairs of -b/-d/-r <pkg> but I think you're right not to
9 implement that. I doubt that it's common to need to mix -b/-d/-r.
10
11 Thanks!

Replies