Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH v2 2/3] distutils-r1.eclass: Use python_has_version in ...enable_sphinx
Date: Thu, 10 Feb 2022 23:39:49
Message-Id: cf6714f82b2c9343dd67d24d494bff106cf82417.camel@gentoo.org
In Reply to: Re: [gentoo-dev] [PATCH v2 2/3] distutils-r1.eclass: Use python_has_version in ...enable_sphinx by Matt Turner
1 On Thu, 2022-02-10 at 15:27 -0800, Matt Turner wrote:
2 > On Thu, Feb 10, 2022 at 6:45 AM Michał Górny <mgorny@g.o> wrote:
3 > >
4 > > Signed-off-by: Michał Górny <mgorny@g.o>
5 >
6 >
7 > Looks good to me. I noticed that this implementation takes only a
8 > single -b/-d/-r as the initial argument and then a list of packages.
9 > I'd suggested pairs of -b/-d/-r <pkg> but I think you're right not to
10 > implement that. I doubt that it's common to need to mix -b/-d/-r.
11 >
12
13 Yeah, I think having options affect only a subset of arguments would
14 be confusing at best.
15
16 --
17 Best regards,
18 Michał Górny