| 1 |
On Mon, 2 Nov 2015 04:44:39 +1100 |
| 2 |
Michael Palimaka <kensington@g.o> wrote: |
| 3 |
|
| 4 |
> There's been a lot of discussion about relying on GitHub for pull |
| 5 |
> requests and code review and such, so I have set up a Phabricator |
| 6 |
> instance against gentoo.git to see how a free alternative might work. |
| 7 |
> |
| 8 |
> Here's a few examples of how things could work: |
| 9 |
> |
| 10 |
> General post-commit review: |
| 11 |
> http://phabricator.astralcloak.net/rGENTOO27ba62d0c7fcabdc79ce82a064b43d67b3b11cca |
| 12 |
> |
| 13 |
> Tracking commits with issues that need attention: |
| 14 |
> http://phabricator.astralcloak.net/audit/query/open/ |
| 15 |
> |
| 16 |
> Pre-commit review: http://phabricator.astralcloak.net/D1 |
| 17 |
> |
| 18 |
> Phabricator also has all sorts of fancy (optional) features that could |
| 19 |
> be useful for collaborative development (see http://phabricator.org/ for |
| 20 |
> more info). |
| 21 |
> |
| 22 |
> What do you think? |
| 23 |
|
| 24 |
At a first glance -- terribly unreadable, wtf is all that tiny stuff |
| 25 |
thrown at me all at once? But I guess we can get used to it, or get |
| 26 |
some kind of sane theme. Tiny, gray text on a little brighter gray |
| 27 |
background with some more shades of gray-cyan around doesn't help |
| 28 |
readability at all. |
| 29 |
|
| 30 |
What's the deal with 'rGENTOO56bd759df1d0'? Can't it be made to use |
| 31 |
normal commit hashes, or at least put some separator in that? I know |
| 32 |
enlightenment people like this kind of stuff but it's neither friendly, |
| 33 |
not readable. And it's going to make copy-paste harder. |
| 34 |
|
| 35 |
Second thought, it's slow. I mean, I open a directory and wait a few |
| 36 |
seconds for detailed information to appear, with my CPU getting hot for |
| 37 |
no good reason. I can only guess how hot the server gets in the |
| 38 |
meantime... |
| 39 |
|
| 40 |
GitHub registration is a nice touch. Sad you need to retype the e-mail |
| 41 |
address though. |
| 42 |
|
| 43 |
Again, the GUI is far from intuitive. Can inline comments be added only |
| 44 |
in diff mode? Since it doesn't want to show the diff for 'huge' |
| 45 |
commits, this prevents us from commenting in some contexts. |
| 46 |
|
| 47 |
Does it actually support pull requests at all? All I was able to find |
| 48 |
was ability to paste a diff... |
| 49 |
|
| 50 |
-- |
| 51 |
Best regards, |
| 52 |
Michał Górny |
| 53 |
<http://dev.gentoo.org/~mgorny/> |
Archives