1 |
Hello Benedikt |
2 |
|
3 |
Sorry for my long response times. |
4 |
|
5 |
On Mon, Jul 23, 2007 at 09:58:17PM +0200, Benedikt Boehm wrote: |
6 |
> i thought about this, but i'd really like to see things like qmail-spp |
7 |
> and the gentoo qmail tarball be handled by the eclass, on the other |
8 |
> hand i agree that unpacking netqmail or qmail based on $FOO is not the |
9 |
> best idea. any suggestions? |
10 |
|
11 |
I really don't see the point of having qmail_spp_src_unpack and all of |
12 |
these qmail-spp related variables. There have to be different diffs |
13 |
anyway for other sources, making it more complicated with that many |
14 |
variables. Aren't you overengineering here? |
15 |
|
16 |
Now some things I noticed while going through, in no special order: |
17 |
- Why need_qmail? It slows down cache regeneration and is really unneeded. |
18 |
- In qmail_man_install you rename some manpages. Can you please add a |
19 |
comment on why you do this? |
20 |
- You're very inconsistent with variable quoting. Please quote them |
21 |
everywhere except the places where you're absolutly sure there will be |
22 |
no spaces (or other special characters) in them. Maybe the original |
23 |
netqmail has some of these issues, too, but now we can fix them. |
24 |
- Don't align stuff like on the last two lines in qmail_src_install. |
25 |
- The "use gencertdaily" thing in qmail_ssl_generate works, but doesn't |
26 |
look so nice. How about this? |
27 |
use gencertdaily && \ |
28 |
CRON_FOLDER=cron.daily || \ |
29 |
CRON_FOLDER=cron.hourly |
30 |
- Limit line length to 80 characters (with tabs at 8 spaces). |
31 |
- I don't like the custom tarball. How do you want to build and |
32 |
redistribute it without depending on a single person? Its sources need |
33 |
to reside completly on Gentoo infrastructure. |
34 |
- If I remember correctly, elog shouldn't be used for empty lines like |
35 |
in qmail_supervise_config_notice. Use echo instead for them. |
36 |
|
37 |
So, now you should have something to chew on again. :-) |
38 |
|
39 |
Thanks, |
40 |
Michael |
41 |
|
42 |
-- |
43 |
http://hansmi.ch/ |