Re: [gentoo-dev] My first ebuild: GNU Hello

[Spider]

begin  quote
On Wed, 19 Nov 2003 12:39:34 +0000 (UTC)
Marco Maggesi <maggesi@××××××××××.fr> wrote:

> Hello,
>
> I am looking for someone to review my first attempt at writing an
> ebuild.  Please look at:
>
>   http://www.math.unifi.it/~maggesi/portage/app-misc/hello/

SRC_URI="http://ftp.gnu.org/gnu/hello/hello-2.1.1.tar.gz"

use 
SRC_URI="http://ftp.gnu.org/gnu/${PN}/${P}.tar.gz" 
instead, as its less intense on maintainance (no need to update inside
the ebuild for a simple bump)





KEYWORDS="x86 ~alpha ~ppc ~mips ~hppa ~sparc arm"

Is that really right? has it had testing by developer on all the
~<arch>?
has it really been in the tree for long enough to be deemed a stable
ebuild on both x86 and arm?




Don't emake  and econf both fail if they fail, making || die ""  
unnecessary and even impossible?




There's no ChangeLog in the directory.



> I have a question, also: how can I figure out the good values for
> DEPEND and RDEPEND?  (Without reading all the sources, of course).

configure.in is usually a good source.

README too.

And unpacking an empty stage3 and testing in works



//Spider

-- 
begin  .signature
This is a .signature virus! Please copy me into your .signature!
See Microsoft KB Article Q265230 for more information.
end