Re: [gentoo-dev] Standardise the variable for including eclasses only once

[Michał Górny]

Dnia 2014-07-04, o godz. 11:26:01
Ulrich Mueller <ulm@g.o> napisał(a):

> Since names like _USER or _PAM look a little dangerous, I suggest
> _<eclassname>_ECLASS for the variable's name.
>
> I have no strong preference for the variable's value. Is testing for
> a non-empty value sufficient? Then we should assign something simple
> (like "1"). If not, any string that is sufficiently random (like the
> one used in eutils) should be good.

I'd rather go for simple value and simple test. Exact tests with weird
names are more prone to mistakes, and this is not something you usually
test.

While at it, I would also like to ask all eclasses to keep
EXPORT_FUNCTIONS *outside* the ifs to keep the exports consistent with
inherits. Otherwise, indirect inheritance influences effectively
exported phase functions and changes in 'inherit' order may affect
exported functions seemingly randomly.

-- 
Best regards,
Michał Górny