Gentoo Archives: gentoo-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Usage of econf with an additional || die
Date: Tue, 30 Sep 2008 10:39:22
Message-Id: 48E201CA.8000308@gentoo.org
In Reply to: Re: [gentoo-dev] Usage of econf with an additional || die by Peter Volkov
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 Peter Volkov wrote:
5 > В Вск, 28/09/2008 в 20:24 +0200, Thomas Sachau пишет:
6 >> I see many ebuild that still use "econf || die", also econf should die by itself. Are there any
7 >> specific reasons for this? Some cases where econf does not die also it fails? Or some other reason
8 >> for this?
9 >
10 > This || die is redundant. Personally I remove it in every package I
11 > touch and I suggest others do the same. People use our tree to learn how
12 > to write ebuilds, so it's good idea to have consistent syntax in our
13 > ebuilds...
14 >
15
16 I suppose it depends on your notion of consistent. Does having econf
17 behave differently from every other function seem consistent to you? :)
18 - --
19 Thanks,
20 Zac
21 -----BEGIN PGP SIGNATURE-----
22 Version: GnuPG v2.0.9 (GNU/Linux)
23
24 iEYEARECAAYFAkjiAckACgkQ/ejvha5XGaOAJgCeJKoJvmR2jxQvHZpaa6FplJ7c
25 fgYAn25YS4vGXahxC1QA3QmJR7yC3D/W
26 =da+4
27 -----END PGP SIGNATURE-----