| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Dne 3.1.2010 01:56, Mark Bateman napsal(a): |
| 5 |
> There seems to be alot of unquoted variables |
| 6 |
> |
| 7 |
> 65 base_src_util $@ |
| 8 |
This is not problem |
| 9 |
> |
| 10 |
> 90 case $1 in |
| 11 |
Yarp this is problem and fixed |
| 12 |
> |
| 13 |
> 95 [[ ! -z "${A}" ]] && unpack ${A} |
| 14 |
${A} is not used quoted :] |
| 15 |
> |
| 16 |
> 117 oldval=${EPATCH_SOURCE} |
| 17 |
> 118 EPATCH_SOURCE=${x} |
| 18 |
> 120 EPATCH_SOURCE=${oldval} |
| 19 |
Variables assignment is not requiring quoting. |
| 20 |
> |
| 21 |
> Also a typo: an "n" slipped in |
| 22 |
> 130 popd > n/dev/null |
| 23 |
Great spot, fixed |
| 24 |
|
| 25 |
Thanks for your help with review :] |
| 26 |
|
| 27 |
Tom |
| 28 |
-----BEGIN PGP SIGNATURE----- |
| 29 |
Version: GnuPG v2.0.14 (GNU/Linux) |
| 30 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ |
| 31 |
|
| 32 |
iEYEARECAAYFAks/+UkACgkQHB6c3gNBRYfBqQCcC3iJXXHsGWLyQg2Ab8+/wH0h |
| 33 |
/BgAoKxzfgbhl0MbKh8UUn1hTJyTzo1z |
| 34 |
=Fv6C |
| 35 |
-----END PGP SIGNATURE----- |
Archives