| 1 |
On Tue, Sep 23, 2008 at 4:21 PM, Bo Ørsted Andresen <bo.andresen@××××.dk> wrote: |
| 2 |
> On Tuesday 23 September 2008 21:39:52 Thomas Sachau wrote: |
| 3 |
>> default_src_install() { |
| 4 |
>> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then |
| 5 |
>> if emake DESTDIR="${D} install || einstall ; then |
| 6 |
>> die "install failed" |
| 7 |
>> else |
| 8 |
>> if [[ -n ${DOCS} ]]; then |
| 9 |
>> dodoc ${DOCS} || die "dodoc failed" |
| 10 |
>> fi |
| 11 |
>> fi |
| 12 |
>> fi |
| 13 |
>> } |
| 14 |
>> |
| 15 |
>> Any more comments? Good? Bad? Interested? |
| 16 |
> |
| 17 |
> Now figure out the four flaws in the above code. |
| 18 |
|
| 19 |
Why not be helpful and point them out? |
| 20 |
|
| 21 |
I would call your comment 'UnGentooey', if I may use a work term. I |
| 22 |
don't think saying there are flaws in a given piece of code is really |
| 23 |
helpful to anyone. |
| 24 |
|
| 25 |
-Alec |
| 26 |
|
| 27 |
> |
| 28 |
> -- |
| 29 |
> Bo Andresen |
| 30 |
> |
Archives