Gentoo Archives: gentoo-dev

From: "Tomáš Chvátal" <scarabeus@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass
Date: Mon, 05 Jul 2010 16:38:02
Message-Id: 4C3209F9.9060503@gentoo.org
In Reply to: Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass by Arfrever Frehtes Taifersar Arahesis
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a):
> 2010-07-05 18:26:40 Samuli Suominen napisał(a): >> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote: >>> 2010-07-05 18:13:26 Samuli Suominen napisał(a): >>>> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: >>>>> These minor changes in python.eclass and distutils.eclass have been already >>>>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar >>>>> with internals of current code before trying to understand these minor changes. >>>>> Suggestions about indentation and quoting will be rejected. >>>>> >>>> >>>> You have been already told to get rid of all the color customizations in >>>> the python eclasses here: >>>> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2 >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3 >>>> >>>> [ .. ] >>>> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 >>>> >>>> The bug was wrongly closed as fixed, as it's not really fixed before >>>> it's all punted >>> >>> Colors can be used with echo. >>> >> >> Stop using echo for output and switch to standard output functions, like >> einfo/eerror/elog/... like told in >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 > > You should read relevant part of comment #7: > "The colors can of course be continued to be used in outputs that are purely build > time outputting and not for communicating things for users like what cmake builds do." > > python.eclass uses colors for build time outputting, which doesn't communicate anything for users. >
+ echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON variable is deprecated and will be banned on 2010-10-01.${_NORMAL}" + echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of NEED_PYTHON variable.${_NORMAL}" + echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please report a bug, if it has not been already reported.${_NORMAL}" The above is build outputting since when? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAkwyCfkACgkQHB6c3gNBRYd2yQCgrpR4HKMnCIqyRbN9eAomZwRK b8oAnjBW16mkxb7B5hpbqZXN5IQ4W4oy =xV10 -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-dev] Minor changes in python.eclass and distutils.eclass Arfrever Frehtes Taifersar Arahesis <Arfrever@g.o>