Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: x11@g.o
Subject: [gentoo-dev] [RFC/PATCH] A cleaner API for virtualx.eclass
Date: Mon, 11 Feb 2013 22:14:52
Message-Id: 1360620883-22562-1-git-send-email-mgorny@gentoo.org
1 Hello, fellow developers,
2
3 The current virtualx.eclass API is a bit insane. It seems a bit like
4 stacking of a few next APIs, mostly designed to quickly run 'make
5 check', then extended to general functions.
6
7 For example running a function 'run_tests' with parameter '--foo' would
8 look like:
9
10 VIRTUALX_COMMAND=run_tests virtualmake --foo
11
12 which is really awful, considering that '--foo' is a parameter to
13 'run_tests' and not virtualmake.
14
15 My patches introduce a single wrapper with argv-as-parameter syntax.
16 That is, the fore-mentioned example would look like:
17
18 virtualx run_tests --foo
19
20 Depending on the maintainer decisions and your feedback, I believe that
21 even all the X* short-hand functions could be deprecated. They are a bit
22 shorter:
23
24 Xemake check
25
26 vs:
27
28 virtualx emake check
29
30 but I don't think that's much of a difference.
31
32 What are your thoughts?

Replies