1 |
Hi Ned, |
2 |
|
3 |
I like the patch - there are probably many cases where a package does |
4 |
not cross compile properly when include paths are not fixed. In those |
5 |
cases, it would be necessary to patch the source on an |
6 |
ebuild-by-ebuild basis. This would eliminate the need to fix the files |
7 |
at an ebuild level with a relatively inexpensive check. |
8 |
|
9 |
Mike has a couple of good points too - unless it's necessary to use |
10 |
thee function from outside gcc or whatever library it ends up in, it |
11 |
may as well be marked static. Path vs name ? I think path. Regarding |
12 |
arbitrary non-standard include paths that could generate false |
13 |
positives, i have no comment. |
14 |
|
15 |
Regarding path normalization ( "//" => "/" ) - in my opinion, if gcc |
16 |
doesn't already do it, then forget about it - otherwise one would be |
17 |
obliged to fix it for the rest of gcc, no? Keep it short and simple. |
18 |
|
19 |
Depending on the level of community feedback you want, I could help |
20 |
test for a while, or you could just include it in an unstable ~ gcc |
21 |
version and see how the universe reacts to it :) |
22 |
|
23 |
Regards, |
24 |
|
25 |
Chris |
26 |
|
27 |
On Sun, Sep 21, 2008 at 12:12 PM, Ned Ludd <solar@g.o> wrote: |
28 |
> I've been toying with an idea after seeing a patch which would abort() |
29 |
> when it detected host includes for cross compiles. I did not like the |
30 |
> idea of aborting as it prevented me from building pkgs that had the same |
31 |
> headers in $ROOT as /. I did like the fact there was a little QA I could |
32 |
> slip in there. After thinking about it a while. I said fsck the QA and |
33 |
> just fixed the problem. Here is what I came up with for gcc-4.2.4.. |
34 |
> |
35 |
> While in my testing I'm finding this works beautifully. However I'd like |
36 |
> some input from others on what they think of such an idea. |
37 |
> Good/Bad/Other? |
38 |
> |
39 |
> Basic goal detect ^/usr/include and rewrite it to $ROOT/usr/include if |
40 |
> using a cross compiler and ROOT is set. |
41 |
> |
42 |
> |
43 |
> -solar |
44 |
> |
45 |
> |