| 1 |
sön 2012-08-12 klockan 23:42 +0200 skrev Sebastian Pipping: |
| 2 |
> Hello Peter, |
| 3 |
> |
| 4 |
> |
| 5 |
> On 08/12/2012 10:30 PM, Peter Hjalmarsson wrote: |
| 6 |
> > Two concerns. |
| 7 |
> |
| 8 |
> thanks for sharing. |
| 9 |
> |
| 10 |
> |
| 11 |
> > I like your approuch, but: |
| 12 |
> > 1. Safety. source software.sh directly from the file(s) that sources |
| 13 |
> > genkernel.conf |
| 14 |
> > |
| 15 |
> > This way people do not have to come to us to find out what broke when |
| 16 |
> > they accidentally removed a line from genkernel.conf. Will even |
| 17 |
> > genkernel work without a genkernel.conf with that commit? Yes, it did |
| 18 |
> > not before but that is not a reason to not do this right now when we fix |
| 19 |
> > it.;) |
| 20 |
> |
| 21 |
> I'm not sure if that change is possible: |
| 22 |
> |
| 23 |
> GK_SHARE is defined in genkernel.conf: |
| 24 |
> |
| 25 |
> GK_SHARE="${GK_SHARE:-/usr/share/genkernel}" |
| 26 |
> |
| 27 |
> So to source ${GK_SHARE}/defaults/software.sh we first need to know, |
| 28 |
> what ${GK_SHARE} is. If we source genkernel.conf and software.sh after |
| 29 |
> (to address that issue) we lose the ability to override things like the |
| 30 |
> busybox version from genkernel.conf. To workaround it we could source |
| 31 |
> genkernel.conf twice, before and after software.sh but that probably not |
| 32 |
> without new trouble, either. |
| 33 |
> |
| 34 |
|
| 35 |
Yeah, I saw that. Even if re-sourceing genkernel.conf does not bring |
| 36 |
other problem it just does not look very pretty. |
| 37 |
|
| 38 |
I have (untested) code in the branch software-vars that aims to take |
| 39 |
care of this in software.sh . |
| 40 |
It contains two commits that should AFAICS work as long as someone has |
| 41 |
not already set LVM_VER or alike in their shell before running |
| 42 |
genkernel. We could start genkernel by sanitizing everything. However |
| 43 |
saving the user from our config file is one thing, saving a user from |
| 44 |
his clogged shell-environment is another... |
| 45 |
|
| 46 |
> |
| 47 |
> > 2. Documentation. Leave a comment in genkernel.conf that all those |
| 48 |
> > things have been moved, and but still can be overridden from there IF |
| 49 |
> > needed. |
| 50 |
> |
| 51 |
> Done: |
| 52 |
> http://git.overlays.gentoo.org/gitweb/?p=proj/genkernel.git;a=commitdiff;h=35efd0619ef2a849b93884eb63041db3d428be7f |
| 53 |
|
| 54 |
Looks good. It may need to be tweaked by just specify "<...> version |
| 55 |
used in the initramfs <...>" or something like that, But it should |
| 56 |
already be enought to un-confuse users. |
| 57 |
|
| 58 |
Best regards |
| 59 |
Peter |
Archives