Gentoo Archives: gentoo-java

From: Serkan Kaba <serkan@g.o>
To: Alistair Bush <ali_bush@g.o>
Cc: gentoo-java@l.g.o
Subject: Re: [gentoo-java] java-pkg-simple and java-mvn-src eclasses
Date: Sat, 03 Jan 2009 00:23:26
Message-Id: 495EAFEE.20405@gentoo.org
In Reply to: Re: [gentoo-java] java-pkg-simple and java-mvn-src eclasses by Alistair Bush
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alistair Bush yazmış:
> Ok, things to note and it would be interesting to see whether other > dev's agree with me: > > java-pkg-simple.eclass: > > 1) inherit java-utils-2 (this is required) instead of java-pkg-2. Add > checks to ensure java-pkg-2 is inheritted (so ebuild does it). > 2) create the jar within src_compile, not src install. > 3) I would like to see var's like JAVA_SRC_DIR(S) so that > java-pkg_dosrc and javadoc could be generated and installed. See what > you can do :) > > java-mvn-src.eclass: > Have this inherit from java-pkg-simple.eclass > Im also concerned about how you are attempting to download a single > file from multiple locations. Im told it is valid, but would rather set > it up as a thirdpartymirror. > > *.ebuilds: > inherit java-pkg-2 [java-pkg-simple java-mvn-src] > > With the eclasses i'm trying to make them as similar to the layout (and > relationships) of java-pkg-2 and java-ant-2 > > Martin von Gagern wrote: >> Hi! >> >> I propose two new eclasses. One is for building java packages from their >> *.java source files, without any additional build instructions. The >> second builds on it and is intended for source bundles exported by the >> source:jar goal of Maven2. Two parts of istack-commons can be bumped >> using these, in order to address https://bugs.gentoo.org/188015 . >> >> I would like to commit all of these to java-experimental if there are no >> objectsion. If you leave the Subject in place, I will catch replies to >> this list. Otherwise please Cc me personally, as I don't read every mail >> to the list. >> >> On IRC selckin1 said: "simple eclass to build simple java packages has >> been proposed many times. my main question would be why doesn't it exist >> allready, this been suggested many times going back years, must be a >> reason." Any input on this would be useful as well. > > My only concern with "simple eclasses" is it could compile, bundle and > install > tests, or even more concerning be used to bypass > a "better" build system that includes unit tests, etc, etc.
ejunit can be helpful there. But ant suits better imo. We can have a more generic build.xml (possibly included with one of our own tools or created in the eclass itself) and an option for the ebuilds to use their own build.xml files as well (As already done in tree) Having an option to override the default build.xml will help to overcome packages which doesn't fit to generic. But still we should see if there are more generaliations than exceptions.
> >> Greetings, >> Martin von Gagern (aka MvG) >> > > >
- -- Sincerely, Serkan KABA Gentoo/Java -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkler+4ACgkQRh6X64ivZaJ0cgCcCJKF8kxr+xpLM/jvQ1gT08zE II0An0kyaMNulk1lUmwzGzSQpcySxbVk =BR4r -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-java] java-pkg-simple and java-mvn-src eclasses Alistair Bush <ali_bush@g.o>