Re: [gentoo-java] RFC: Default src_compile for java-pkg-2.eclass

[Joshua Nichols]

How many packages would benefit from this?

Some ways to improve it... maybe have two variables, ie 
EANT_BUILD_TARGET, EANT_DOC_TARGET,  which could be set and respected by 
src_compile, ie:

java-pkg-2_src_compile() {
	local antflags="${EANT_BUILD_TARGET:=jar}"
	hasq doc ${IUSE} && antflags="${antflags} $(use_doc ${EANT_DOC_TARGET})"
	eant ${antflags}
}

By adding that, I think more ebuilds would be able to take advantage of it.

One other thing... should definately check for the existence of a 
build.xml... and additionally, could have a variable to specify where 
the build file lives.

Petteri Räty wrote:
> I was looking at the output of qgrep eant to see how our ebuilds usually
> call eant and came up with the attached src_compile.
>
> Regards,
> Petteri
>
> ------------------------------------------------------------------------
>
> Index: java-pkg-2.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/java-pkg-2.eclass,v
> retrieving revision 1.5
> diff -u -r1.5 java-pkg-2.eclass
> --- java-pkg-2.eclass	8 Dec 2006 12:12:04 -0000	1.5
> +++ java-pkg-2.eclass	9 Dec 2006 12:16:15 -0000
> @@ -33,7 +33,7 @@
>  # ------------------------------------------------------------------------------
>  RDEPEND="${DEPEND}"
>
> -EXPORT_FUNCTIONS pkg_setup
> +EXPORT_FUNCTIONS pkg_setup src_compile
>
>  # ------------------------------------------------------------------------------
>  # @eclass-pkg_setup
> @@ -46,6 +46,17 @@
>  }
>
>  # ------------------------------------------------------------------------------
> +# @eclass-src_compile
> +#
> +# Default src_compile for java packages
> +# ------------------------------------------------------------------------------
> +java-pkg-2_src_compile() {
> +	local antflags="jar"
> +	hasq doc ${IUSE} && antflags="${antflags} $(use_doc)"
> +	eant ${antflags}
> +}
> +
> +# ------------------------------------------------------------------------------
>  # @note
>  #
>  # We need to initialize the environment in every function because Portage
>


-- 
Joshua Nichols
Gentoo/Java Project Lead
-- 
gentoo-java@g.o mailing list