| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
Joshua Nichols wrote: |
| 5 |
> How many packages would benefit from this? |
| 6 |
> |
| 7 |
> Some ways to improve it... maybe have two variables, ie |
| 8 |
> EANT_BUILD_TARGET, EANT_DOC_TARGET, which could be set and respected by |
| 9 |
> src_compile, ie: |
| 10 |
> |
| 11 |
> java-pkg-2_src_compile() { |
| 12 |
> local antflags="${EANT_BUILD_TARGET:=jar}" |
| 13 |
> hasq doc ${IUSE} && antflags="${antflags} $(use_doc |
| 14 |
> ${EANT_DOC_TARGET})" |
| 15 |
> eant ${antflags} |
| 16 |
> } |
| 17 |
> |
| 18 |
> By adding that, I think more ebuilds would be able to take advantage of it. |
| 19 |
> |
| 20 |
|
| 21 |
I wonder if ebuild using those variables would be more typing than |
| 22 |
ebuild with own src_compile() :) but not a bad idea anyway. |
| 23 |
|
| 24 |
> One other thing... should definately check for the existence of a |
| 25 |
> build.xml... and additionally, could have a variable to specify where |
| 26 |
> the build file lives. |
| 27 |
|
| 28 |
Yeah check is needed, otherwise you'll be trying to compile current -bin |
| 29 |
packages without src_compile() in ebuild... |
| 30 |
Not sure if any ebuild would use the variable, but why not... |
| 31 |
- -- |
| 32 |
Vlastimil Babka (Caster) |
| 33 |
Gentoo/Java |
| 34 |
-----BEGIN PGP SIGNATURE----- |
| 35 |
Version: GnuPG v1.4.6 (GNU/Linux) |
| 36 |
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org |
| 37 |
|
| 38 |
iD8DBQFFfToKtbrAj05h3oQRAjklAJ95WFKtG/l9BXPwA3CvFwbprYXEVACaArRY |
| 39 |
nVl3h/IW+wfgYx0hyvUWvqc= |
| 40 |
=d2lM |
| 41 |
-----END PGP SIGNATURE----- |
| 42 |
-- |
| 43 |
gentoo-java@g.o mailing list |
Archives