| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 27/10/14 09:22, Alexander Berntsen wrote: |
| 5 |
> On 27/10/14 08:33, Zac Medico wrote: |
| 6 |
>> + if not self._depgraph._virt_deps_visible( + new_child, |
| 7 |
>> ignore_use=True): + continue + if pkg < new_child: + |
| 8 |
>> return False |
| 9 |
> Seems needlessly bit obscure when you could just "if |
| 10 |
> self.depgraph._virt_deps_visible(new_child, ignore_use=True) and pkg |
| 11 |
> < new_child" or some variant thereof. But it's a minor qualm. |
| 12 |
> |
| 13 |
> Otherwise LGTM, go ahead & push. |
| 14 |
Thunderbird fucked up wrapping. I am referring to this part: |
| 15 |
|
| 16 |
On 27/10/14 08:33, Zac Medico wrote:> + for new_child in self._depgraph._iter_similar_available( |
| 17 |
> + pkg, next(iter(atom_set))): |
| 18 |
> + if not self._depgraph._virt_deps_visible( |
| 19 |
> + new_child, ignore_use=True): |
| 20 |
> + continue |
| 21 |
> + if pkg < new_child: |
| 22 |
> + return False |
| 23 |
- -- |
| 24 |
Alexander |
| 25 |
bernalex@g.o |
| 26 |
https://secure.plaimi.net/~alexander |
| 27 |
-----BEGIN PGP SIGNATURE----- |
| 28 |
Version: GnuPG v2 |
| 29 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 30 |
|
| 31 |
iF4EAREIAAYFAlROAP4ACgkQRtClrXBQc7XIhAD8CStcQaeCbFzibcHf0CAHN/71 |
| 32 |
xyUKhSWcoky/LUt0gB8A/2WC8wwngghQjbhwEJ0WFryygLmvvTdhGBl2K7/9Xq7Q |
| 33 |
=Diyd |
| 34 |
-----END PGP SIGNATURE----- |
Archives