| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 27/10/14 08:33, Zac Medico wrote: |
| 5 |
> + if not self._depgraph._virt_deps_visible( + new_child, |
| 6 |
> ignore_use=True): + continue + if pkg < new_child: + |
| 7 |
> return False |
| 8 |
Seems needlessly bit obscure when you could just "if |
| 9 |
self.depgraph._virt_deps_visible(new_child, ignore_use=True) and pkg < |
| 10 |
new_child" or some variant thereof. But it's a minor qualm. |
| 11 |
|
| 12 |
Otherwise LGTM, go ahead & push. |
| 13 |
|
| 14 |
- -- |
| 15 |
Alexander |
| 16 |
bernalex@g.o |
| 17 |
https://secure.plaimi.net/~alexander |
| 18 |
-----BEGIN PGP SIGNATURE----- |
| 19 |
Version: GnuPG v2 |
| 20 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 21 |
|
| 22 |
iF4EAREIAAYFAlROALYACgkQRtClrXBQc7WY4QEAgp2lH+WOHmAcGBoxVIfr0cGc |
| 23 |
mYc5xIpc17eu4OxvPUIBAIaMsRyieA9OZSq7mUQL27of9zrirjH0PGPMjSuxZQxB |
| 24 |
=1fXi |
| 25 |
-----END PGP SIGNATURE----- |
Archives