| 1 |
On 10/27/2014 01:22 AM, Alexander Berntsen wrote: |
| 2 |
> On 27/10/14 08:33, Zac Medico wrote: |
| 3 |
>> + if not self._depgraph._virt_deps_visible( + new_child, |
| 4 |
>> ignore_use=True): + continue + if pkg < new_child: + |
| 5 |
>> return False |
| 6 |
> Seems needlessly bit obscure when you could just "if |
| 7 |
> self.depgraph._virt_deps_visible(new_child, ignore_use=True) and pkg < |
| 8 |
> new_child" or some variant thereof. But it's a minor qualm. |
| 9 |
|
| 10 |
I prefer not to group them into a single expression because they are |
| 11 |
separate heuristics. At some point in the future, we may find that we |
| 12 |
need to adjust one or both heuristics, add more heuristics, or remove |
| 13 |
some heuristics. Keeping the heuristics as separate expressions makes it |
| 14 |
easier to do such modifications. It also provides emphasis to the reader |
| 15 |
that these are separate heuristics. |
| 16 |
|
| 17 |
> Otherwise LGTM, go ahead & push. |
| 18 |
|
| 19 |
Thanks, it's pushed: |
| 20 |
|
| 21 |
https://github.com/gentoo/portage/commit/d3be49fe6827aa1974856dffe6d5a1aca80a7bed |
| 22 |
-- |
| 23 |
Thanks, |
| 24 |
Zac |
Archives