| 1 |
On 10/25/2014 01:13 PM, Michael Palimaka wrote: |
| 2 |
> On 26/10/14 07:00, Zac Medico wrote: |
| 3 |
>>>> |
| 4 |
>>>> These functions are internals, so they need to be prefixed with __ like |
| 5 |
>>>> __eqalog and __eqawarnlog. |
| 6 |
>>>> |
| 7 |
>>> |
| 8 |
>>> Also, please unset them inside bin/save-ebuild-env.sh. |
| 9 |
>>> |
| 10 |
>> |
| 11 |
>> Actually, these suggestions are optional, since the environment from |
| 12 |
>> misc-functions.sh is never saved. However, if you wanted to move them to |
| 13 |
>> isolated-functions.sh, then these suggestions are mandatory. |
| 14 |
>> |
| 15 |
> |
| 16 |
> Is it better to move them to isolated-functions and implement the above |
| 17 |
> changes then? I only put it in misc-functions since it's near |
| 18 |
> install_qa_check and I'm not too familiar with the file layout. :-) |
| 19 |
|
| 20 |
Yes, I think so, since eventually you'll probably want to call them |
| 21 |
elsewhere. |
| 22 |
-- |
| 23 |
Thanks, |
| 24 |
Zac |
Archives