[gentoo-portage-dev] Re: [PATCH 1/3] bin/misc-functions.sh: Introduce eqalog and eqawarnlog functions.

[Michael Palimaka]

On 26/10/14 07:00, Zac Medico wrote:
> On 10/25/2014 12:54 PM, Zac Medico wrote:
>> On 10/25/2014 12:53 PM, Zac Medico wrote:
>>> On 10/25/2014 09:15 AM, Michael Palimaka wrote:
>>>> +eqalog() {
>>>> +	local tag=$1 x
>>>> +	shift
>>>> +	for x in "$@" ; do
>>>> +		echo "${tag}" "${x}" >> "${T}"/qa.log
>>>> +	done
>>>> +}
>>>> +
>>>> +eqawarnlog() {
>>>> +	eqalog "$@"
>>>> +	shift
>>>> +	for x in "$@" ; do
>>>> +		eqawarn "  $x"
>>>> +	done
>>>> +}
>>>> +
>>>
>>> These functions are internals, so they need to be prefixed with __ like
>>> __eqalog and __eqawarnlog.
>>>
>>
>> Also, please unset them inside bin/save-ebuild-env.sh.
>>
>
> Actually, these suggestions are optional, since the environment from
> misc-functions.sh is never saved. However, if you wanted to move them to
> isolated-functions.sh, then these suggestions are mandatory.
>

Is it better to move them to isolated-functions and implement the above
changes then? I only put it in misc-functions since it's near
install_qa_check and I'm not too familiar with the file layout. :-)