| 1 |
On Thu, Nov 29, 2007 at 02:31:07AM +0100, Johan Hattne wrote: |
| 2 |
> |
| 3 |
> On Nov 28, 2007, at 21:33 , Elias Pipping wrote: |
| 4 |
> |
| 5 |
>> On Wed, Nov 28, 2007 at 05:17:44PM +0100, Johan Hattne wrote: |
| 6 |
>>> Two issues with the tk-8.4.16-r1 ebuild on x86-macos: |
| 7 |
>>> |
| 8 |
>>> (1) There is what looks like typo ("EPEFIX" instead of "EPREFIX"). |
| 9 |
>>> |
| 10 |
>>> (2) The adjustment of the CC_ and LD_SEARCH_FLAGS is unconditional, |
| 11 |
>>> whereas |
| 12 |
>>> in the tcl ebuild it's conditional for darwin. I find I need to have the |
| 13 |
>>> SEARCH_FLAGS sed conditional in tk, too. |
| 14 |
>>> |
| 15 |
>>> With attached diff, tk can be merged on x86-macos. Could you please |
| 16 |
>>> keyword it accordingly? |
| 17 |
>> |
| 18 |
>> Committed[1], thanks |
| 19 |
> |
| 20 |
> Thanks! The sed got a bit funny, though: |
| 21 |
> |
| 22 |
> [[ ${CHOST} != *-darwin* ]] && sed blablabla || die |
| 23 |
> |
| 24 |
> should be |
| 25 |
> |
| 26 |
> [[ ${CHOST} != *-darwin* ]] && ( sed blablabla || die ) |
| 27 |
> |
| 28 |
> shouldn't it? Or maybe the if ... else is clearer? |
| 29 |
|
| 30 |
No, that's perfectly fine ;) |
| 31 |
|
| 32 |
The if ... else construct was avoided to keep the difference to the |
| 33 |
non-prefix tree small. |
| 34 |
|
| 35 |
Also, there's no need for a sub-shell here. iirc, dying in a subshell |
| 36 |
wouldn't even be fatal. |
| 37 |
|
| 38 |
|
| 39 |
-- Elias |
Archives