| 1 |
On Nov 28, 2007, at 21:33 , Elias Pipping wrote: |
| 2 |
|
| 3 |
> On Wed, Nov 28, 2007 at 05:17:44PM +0100, Johan Hattne wrote: |
| 4 |
>> Two issues with the tk-8.4.16-r1 ebuild on x86-macos: |
| 5 |
>> |
| 6 |
>> (1) There is what looks like typo ("EPEFIX" instead of "EPREFIX"). |
| 7 |
>> |
| 8 |
>> (2) The adjustment of the CC_ and LD_SEARCH_FLAGS is |
| 9 |
>> unconditional, whereas |
| 10 |
>> in the tcl ebuild it's conditional for darwin. I find I need to |
| 11 |
>> have the |
| 12 |
>> SEARCH_FLAGS sed conditional in tk, too. |
| 13 |
>> |
| 14 |
>> With attached diff, tk can be merged on x86-macos. Could you please |
| 15 |
>> keyword it accordingly? |
| 16 |
> |
| 17 |
> Committed[1], thanks |
| 18 |
|
| 19 |
Thanks! The sed got a bit funny, though: |
| 20 |
|
| 21 |
[[ ${CHOST} != *-darwin* ]] && sed blablabla || die |
| 22 |
|
| 23 |
should be |
| 24 |
|
| 25 |
[[ ${CHOST} != *-darwin* ]] && ( sed blablabla || die ) |
| 26 |
|
| 27 |
shouldn't it? Or maybe the if ... else is clearer? |
| 28 |
|
| 29 |
// Cheers; Johan |
| 30 |
|
| 31 |
-- |
| 32 |
gentoo-alt@g.o mailing list |
Archives