Gentoo Archives: gentoo-catalyst

From:	Daniel Cordero <gentoo.catalyst@××××.io>
To:	gentoo-catalyst@l.g.o
Subject:	[gentoo-catalyst] [PATCH 2/4] stage4/groups: don't run split on a list
Date:	Thu, 21 Apr 2022 07:08:50
Message-Id:	`20220421070826.92638-2-gentoo.catalyst@0xdc.io`
In Reply to:	[gentoo-catalyst] [PATCH 1/4] stage4: fix handling of groups, users and keys by Daniel Cordero

1	"groups" has been normalised into a list and does not have a split()
2	method.
3
4	This fixes an issue introduced in commit 5be6069bcbd5a7fa3f114f28366597bc5ddbb891.
5	---
6	catalyst/base/stagebase.py \| 2 +-
7	1 file changed, 1 insertion(+), 1 deletion(-)
8
9	diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
10	index 1d71c59d..7e6b9e32 100644
11	--- a/catalyst/base/stagebase.py
12	+++ b/catalyst/base/stagebase.py
13	@@ -931,7 +931,7 @@ class StageBase(TargetBase, ClearBase, GenBase):
14	env=self.env)
15
16	def groups(self):
17	- for x in self.settings["groups"].split():
18	+ for x in self.settings["groups"]:
19	log.notice("Creating group: '%s'", x)
20	cmd(["groupadd", "-R", self.settings['chroot_path'], x], env=self.env)
21
22	--
23	2.35.1