Gentoo Archives: gentoo-catalyst

From: Daniel Cordero <gentoo.catalyst@××××.io>
To: gentoo-catalyst@l.g.o
Subject: [gentoo-catalyst] [PATCH 1/4] stage4: fix handling of groups, users and keys
Date: Thu, 21 Apr 2022 07:08:43
Message-Id: 20220421070826.92638-1-gentoo.catalyst@0xdc.io
In Reply to: Re: [gentoo-catalyst] [PATCH 1/3] catalyst: support 3 new options by Matt Turner
1 Previously, the set_*() functions would always set the result of the toml parsing
2 as the setting. Instead, only override it if it is a string.
3
4 This fixes an issue introduced in commit 5be6069bcbd5a7fa3f114f28366597bc5ddbb891.
5 ---
6 catalyst/base/stagebase.py | 6 +++---
7 1 file changed, 3 insertions(+), 3 deletions(-)
8
9 diff --git a/catalyst/base/stagebase.py b/catalyst/base/stagebase.py
10 index 5c7e9adb..1d71c59d 100644
11 --- a/catalyst/base/stagebase.py
12 +++ b/catalyst/base/stagebase.py
13 @@ -589,9 +589,9 @@ class StageBase(TargetBase, ClearBase, GenBase):
14 def set_groups(self):
15 groups = self.settings["spec_prefix"] + "/groups"
16 if groups in self.settings:
17 + self.settings["groups"] = self.settings[groups]
18 if isinstance(self.settings[groups], str):
19 self.settings["groups"] = self.settings[groups].split(",")
20 - self.settings["groups"] = self.settings[groups]
21 del self.settings[groups]
22 else:
23 self.settings["groups"] = []
24 @@ -600,9 +600,9 @@ class StageBase(TargetBase, ClearBase, GenBase):
25 def set_users(self):
26 users = self.settings["spec_prefix"] + "/users"
27 if users in self.settings:
28 + self.settings["users"] = self.settings[users]
29 if isinstance(self.settings[users], str):
30 self.settings["users"] = self.settings[users].split(",")
31 - self.settings["users"] = self.settings[users]
32 del self.settings[users]
33 else:
34 self.settings["users"] = []
35 @@ -611,9 +611,9 @@ class StageBase(TargetBase, ClearBase, GenBase):
36 def set_ssh_public_keys(self):
37 ssh_public_keys = self.settings["spec_prefix"] + "/ssh_public_keys"
38 if ssh_public_keys in self.settings:
39 + self.settings["ssh_public_keys"] = self.settings[ssh_public_keys]
40 if isinstance(self.settings[ssh_public_keys], str):
41 self.settings["ssh_public_keys"] = self.settings[ssh_public_keys].split(",")
42 - self.settings["ssh_public_keys"] = self.settings[ssh_public_keys]
43 del self.settings[ssh_public_keys]
44 else:
45 self.settings["ssh_public_keys"] = []
46 --
47 2.35.1

Replies