Gentoo Archives: gentoo-catalyst

From: "Andreas K. Huettel" <dilfridge@g.o>
To: gentoo-catalyst@l.g.o
Cc: Daniel Cordero <gentoo.catalyst@××××.ws>
Subject: Re: [gentoo-catalyst] [PATCH] create-iso.sh: split iso-level arguments
Date: Sat, 23 Apr 2022 11:00:08
Message-Id: 2208736.iZASKD2KPV@pinacolada
In Reply to: [gentoo-catalyst] [PATCH] create-iso.sh: split iso-level arguments by Daniel Cordero
1 Huh... fine of course and sorry about that.
2 Strange that it worked though...
3
4 Am Dienstag, 19. April 2022, 19:40:15 CEST schrieb Daniel Cordero:
5 > From: Daniel Cordero <catalyst@××××.io>
6 >
7 > When enclosed in quotes and expanded with "${variable[@]}", the word is expanded
8 > to be a single argument, rather than two separate arguments.
9 >
10 > i.e. argv[2] = "-iso-level 3"
11 > instead of
12 > argv[2] = "-iso-level"
13 > argv[3] = "3"
14 >
15 > This lead to the failure:
16 > xorriso : FAILURE : -as mkisofs: Unrecognized option '-iso-level 3'
17 > xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'
18 > grub-mkrescue: error: `xorriso` invocation failed
19 >
20 > This patch fixes commit 0b56dbe4d36c88b0b051d24451e15cd6b64c819d.
21 > ---
22 > targets/support/create-iso.sh | 2 +-
23 > 1 file changed, 1 insertion(+), 1 deletion(-)
24 >
25 > diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
26 > index 45ef1696..9991b930 100755
27 > --- a/targets/support/create-iso.sh
28 > +++ b/targets/support/create-iso.sh
29 > @@ -194,7 +194,7 @@ case ${clst_hostarch} in
30 > amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86)
31 > isoroot_checksum
32 >
33 > - extra_opts=("-joliet" "-iso-level 3")
34 > + extra_opts=("-joliet" "-iso-level" "3")
35 > case ${clst_hostarch} in
36 > sparc*) extra_opts+=("--sparc-boot") ;;
37 > esac
38 >
39
40
41 --
42 Andreas K. Hüttel
43 dilfridge@g.o
44 Gentoo Linux developer
45 (council, toolchain, base-system, perl, libreoffice)