Gentoo Archives: gentoo-catalyst

From: Daniel Cordero <gentoo.catalyst@××××.ws>
To: gentoo-catalyst@l.g.o
Subject: [gentoo-catalyst] [PATCH] create-iso.sh: split iso-level arguments
Date: Tue, 19 Apr 2022 17:40:52
Message-Id: 20220419174015.3958836-1-gentoo.catalyst@xxoo.ws
1 From: Daniel Cordero <catalyst@××××.io>
2
3 When enclosed in quotes and expanded with "${variable[@]}", the word is expanded
4 to be a single argument, rather than two separate arguments.
5
6 i.e. argv[2] = "-iso-level 3"
7 instead of
8 argv[2] = "-iso-level"
9 argv[3] = "3"
10
11 This lead to the failure:
12 xorriso : FAILURE : -as mkisofs: Unrecognized option '-iso-level 3'
13 xorriso : aborting : -abort_on 'FAILURE' encountered 'FAILURE'
14 grub-mkrescue: error: `xorriso` invocation failed
15
16 This patch fixes commit 0b56dbe4d36c88b0b051d24451e15cd6b64c819d.
17 ---
18 targets/support/create-iso.sh | 2 +-
19 1 file changed, 1 insertion(+), 1 deletion(-)
20
21 diff --git a/targets/support/create-iso.sh b/targets/support/create-iso.sh
22 index 45ef1696..9991b930 100755
23 --- a/targets/support/create-iso.sh
24 +++ b/targets/support/create-iso.sh
25 @@ -194,7 +194,7 @@ case ${clst_hostarch} in
26 amd64|arm64|ia64|ppc*|powerpc*|sparc*|x86)
27 isoroot_checksum
28
29 - extra_opts=("-joliet" "-iso-level 3")
30 + extra_opts=("-joliet" "-iso-level" "3")
31 case ${clst_hostarch} in
32 sparc*) extra_opts+=("--sparc-boot") ;;
33 esac
34 --
35 2.35.1

Replies