1 |
On Mon, 5 Oct 2015 23:48:23 -0400 |
2 |
Mike Frysinger <vapier@g.o> wrote: |
3 |
|
4 |
> Everyone has moved away from these in the python world. |
5 |
> --- |
6 |
> .pylintrc | 2 +- |
7 |
> catalyst/builder.py | 2 +- |
8 |
> catalyst/config.py | 2 +- |
9 |
> catalyst/lock.py | 2 +- |
10 |
> 4 files changed, 4 insertions(+), 4 deletions(-) |
11 |
> |
12 |
> diff --git a/.pylintrc b/.pylintrc |
13 |
> index 7b42caf..5fdbb1f 100644 |
14 |
> --- a/.pylintrc |
15 |
> +++ b/.pylintrc |
16 |
> @@ -37,7 +37,7 @@ load-plugins= |
17 |
> # unidiomatic-typecheck -- convert to isinstance |
18 |
> # redefined-outer-name -- clean up code to not do this |
19 |
> # <all the ones after redefined-outer-name in the list> |
20 |
> -disable=missing-docstring, too-many-lines, locally-enabled, |
21 |
> locally-disabled, too-few-public-methods, too-many-public-methods, |
22 |
> too-many-return-statements, too-many-branches, too-many-arguments, |
23 |
> too-many-function-args, too-many-locals, too-many-statements, |
24 |
> too-many-instance-attributes, fixme, broad-except, bad-whitespace, |
25 |
> bad-continuation, invalid-name, line-too-long, |
26 |
> pointless-string-statement, unused-wildcard-import, |
27 |
> unidiomatic-typecheck, redefined-outer-name, |
28 |
> attribute-defined-outside-init, bad-indentation, bare-except, |
29 |
> global-statement, global-variable-not-assigned, import-error, |
30 |
> mixed-indentation, multiple-statements, no-self-use, |
31 |
> redefined-builtin, reimported, relative-import, superfluous-parens, |
32 |
> super-init-not-called, unused-argument, unused-import, |
33 |
> unused-variable, wildcard-import, bad-builtin, no-init |
34 |
> +disable=missing-docstring, too-many-lines, locally-enabled, |
35 |
> locally-disabled, too-few-public-methods, too-many-public-methods, |
36 |
> too-many-return-statements, too-many-branches, too-many-arguments, |
37 |
> too-many-function-args, too-many-locals, too-many-statements, |
38 |
> too-many-instance-attributes, fixme, broad-except, bad-whitespace, |
39 |
> bad-continuation, invalid-name, line-too-long, |
40 |
> pointless-string-statement, unused-wildcard-import, |
41 |
> unidiomatic-typecheck, redefined-outer-name, |
42 |
> attribute-defined-outside-init, bad-indentation, bare-except, |
43 |
> global-statement, global-variable-not-assigned, mixed-indentation, |
44 |
> multiple-statements, no-self-use, redefined-builtin, reimported, |
45 |
> relative-import, superfluous-parens, super-init-not-called, |
46 |
> unused-argument, unused-import, unused-variable, wildcard-import, |
47 |
> bad-builtin, no-init, unreachable [REPORTS] diff --git |
48 |
> a/catalyst/builder.py b/catalyst/builder.py index ad27d78..3ba86c8 |
49 |
> 100644 --- a/catalyst/builder.py +++ b/catalyst/builder.py @@ -1,5 |
50 |
> +1,5 @@ -class generic: +class generic(object): def |
51 |
> __init__(self,myspec): self.settings=myspec diff --git |
52 |
> a/catalyst/config.py b/catalyst/config.py index 5d74dce..48d9c12 |
53 |
> 100644 --- a/catalyst/config.py +++ b/catalyst/config.py @@ -2,7 +2,7 |
54 |
> @@ import re from catalyst.support import CatalystError -class |
55 |
> ParserBase: +class ParserBase(object): filename = "" lines = None |
56 |
> diff --git a/catalyst/lock.py b/catalyst/lock.py index |
57 |
> 9f954eb..c031258 100644 --- a/catalyst/lock.py +++ b/catalyst/lock.py |
58 |
> @@ -24,7 +24,7 @@ class LockInUse(Exception): print -class LockDir: |
59 |
> +class LockDir(object): locking_method=fcntl.flock |
60 |
> lock_dirs_in_use=[] |
61 |
> die_on_failed_lock=True |
62 |
|
63 |
it's good. |
64 |
|
65 |
-- |
66 |
Brian Dolbec <dolsen> |