Gentoo Archives: gentoo-catalyst

From: Mike Frysinger <vapier@g.o>
To: gentoo-catalyst@l.g.o
Subject: [gentoo-catalyst] [PATCH] lint: stop using old-style classes
Date: Tue, 06 Oct 2015 03:48:32
Message-Id: 1444103303-14652-1-git-send-email-vapier@gentoo.org
1 Everyone has moved away from these in the python world.
2 ---
3 .pylintrc | 2 +-
4 catalyst/builder.py | 2 +-
5 catalyst/config.py | 2 +-
6 catalyst/lock.py | 2 +-
7 4 files changed, 4 insertions(+), 4 deletions(-)
8
9 diff --git a/.pylintrc b/.pylintrc
10 index 7b42caf..5fdbb1f 100644
11 --- a/.pylintrc
12 +++ b/.pylintrc
13 @@ -37,7 +37,7 @@ load-plugins=
14 # unidiomatic-typecheck -- convert to isinstance
15 # redefined-outer-name -- clean up code to not do this
16 # <all the ones after redefined-outer-name in the list>
17 -disable=missing-docstring, too-many-lines, locally-enabled, locally-disabled, too-few-public-methods, too-many-public-methods, too-many-return-statements, too-many-branches, too-many-arguments, too-many-function-args, too-many-locals, too-many-statements, too-many-instance-attributes, fixme, broad-except, bad-whitespace, bad-continuation, invalid-name, line-too-long, pointless-string-statement, unused-wildcard-import, unidiomatic-typecheck, redefined-outer-name, attribute-defined-outside-init, bad-indentation, bare-except, global-statement, global-variable-not-assigned, import-error, mixed-indentation, multiple-statements, no-self-use, redefined-builtin, reimported, relative-import, superfluous-parens, super-init-not-called, unused-argument, unused-import, unused-variable, wildcard-import, bad-builtin, no-init
18 +disable=missing-docstring, too-many-lines, locally-enabled, locally-disabled, too-few-public-methods, too-many-public-methods, too-many-return-statements, too-many-branches, too-many-arguments, too-many-function-args, too-many-locals, too-many-statements, too-many-instance-attributes, fixme, broad-except, bad-whitespace, bad-continuation, invalid-name, line-too-long, pointless-string-statement, unused-wildcard-import, unidiomatic-typecheck, redefined-outer-name, attribute-defined-outside-init, bad-indentation, bare-except, global-statement, global-variable-not-assigned, mixed-indentation, multiple-statements, no-self-use, redefined-builtin, reimported, relative-import, superfluous-parens, super-init-not-called, unused-argument, unused-import, unused-variable, wildcard-import, bad-builtin, no-init, unreachable
19
20
21 [REPORTS]
22 diff --git a/catalyst/builder.py b/catalyst/builder.py
23 index ad27d78..3ba86c8 100644
24 --- a/catalyst/builder.py
25 +++ b/catalyst/builder.py
26 @@ -1,5 +1,5 @@
27
28 -class generic:
29 +class generic(object):
30 def __init__(self,myspec):
31 self.settings=myspec
32
33 diff --git a/catalyst/config.py b/catalyst/config.py
34 index 5d74dce..48d9c12 100644
35 --- a/catalyst/config.py
36 +++ b/catalyst/config.py
37 @@ -2,7 +2,7 @@
38 import re
39 from catalyst.support import CatalystError
40
41 -class ParserBase:
42 +class ParserBase(object):
43
44 filename = ""
45 lines = None
46 diff --git a/catalyst/lock.py b/catalyst/lock.py
47 index 9f954eb..c031258 100644
48 --- a/catalyst/lock.py
49 +++ b/catalyst/lock.py
50 @@ -24,7 +24,7 @@ class LockInUse(Exception):
51 print
52
53
54 -class LockDir:
55 +class LockDir(object):
56 locking_method=fcntl.flock
57 lock_dirs_in_use=[]
58 die_on_failed_lock=True
59 --
60 2.5.2

Replies

Subject Author
Re: [gentoo-catalyst] [PATCH] lint: stop using old-style classes Brian Dolbec <dolsen@g.o>