Gentoo Archives: gentoo-catalyst

From: Brian Dolbec <dolsen@g.o>
To: gentoo-catalyst@l.g.o
Subject: Re: [gentoo-catalyst] Re: [PATCH] targets: Don't delete pyc/pyo files
Date: Wed, 20 May 2020 22:59:24
Message-Id: 20200520155919.59468f92@storm
In Reply to: [gentoo-catalyst] Re: [PATCH] targets: Don't delete pyc/pyo files by Matt Turner
1 On Sat, 16 May 2020 17:38:19 -0700
2 Matt Turner <mattst88@g.o> wrote:
3
4 > On Sat, May 16, 2020 at 4:29 PM Matt Turner <mattst88@g.o>
5 > wrote:
6 > >
7 > > These files are actually owned by their packages now, and removing
8 > > them can break subsequent builds.
9 > >
10 > > See
11 > > https://archives.gentoo.org/gentoo-releng-autobuilds/message/a115781f8e7fb4bd5adfb94a7f2e63b4
12 > >
13 > > Signed-off-by: Matt Turner <mattst88@g.o>
14 > > ---
15 > > I'm minimally concerned about the potential for increasing the size
16 > > of the ISO. I'll report back with numbers.
17 > >
18 > > targets/livecd-stage1/controller.sh | 4 ----
19 > > targets/livecd-stage2/controller.sh | 2 --
20 > > targets/stage1/preclean-chroot.sh | 2 --
21 > > 3 files changed, 8 deletions(-)
22 > >
23 > > diff --git a/targets/livecd-stage1/controller.sh
24 > > b/targets/livecd-stage1/controller.sh index ced2634e..c4572ff9
25 > > 100755 --- a/targets/livecd-stage1/controller.sh
26 > > +++ b/targets/livecd-stage1/controller.sh
27 > > @@ -13,9 +13,5 @@ case $1 in
28 > > ${clst_shdir}/${clst_target}/chroot.sh
29 > > echo "${clst_packages}" >
30 > > ${clst_chroot_path}/tmp/packages.txt ;;
31 > > -
32 > > - clean)
33 > > - find ${clst_chroot_path}/usr/lib -iname "*.pyc"
34 > > -exec rm -f {} \;
35 > > - ;;
36 > > esac
37 > > exit $?
38 > > diff --git a/targets/livecd-stage2/controller.sh
39 > > b/targets/livecd-stage2/controller.sh index 8ee46d7c..0701a26b
40 > > 100755 --- a/targets/livecd-stage2/controller.sh
41 > > +++ b/targets/livecd-stage2/controller.sh
42 > > @@ -85,8 +85,6 @@ case $1 in
43 > > then
44 > > # Clean out man, info and doc files
45 > > rm -rf
46 > > ${clst_chroot_path}/usr/share/{man,doc,info}/*
47 > > - # Zap all .pyc and .pyo files
48 > > - find ${clst_chroot_path}/usr/lib* -iname
49 > > "*.py[co]" -exec rm -f {} \;
50 >
51 > I think we may want to keep this intact for livecd-stage2. The ISO
52 > sizes goes from 286M to 305M.
53 >
54 > What do other people think?
55 >
56
57 Does anyone actually burn CD's anymore? Rarely I think. I stopped
58 putting in a CD/DVD drive in systems years ago. If I did need to, I
59 have several on older machines I can use along with a bunch of unused
60 blanks.
61
62 USB sticks are so cheap and much easier to use with a lot more space to
63 even be able to emerge addtional pkgs on that the livedvd image enables.
64
65 You can get a 5pak of 16gb drives for $20. 5pak of 8GB are $15 or
66 less...
67
68 I wouldn't worry about a few extra bytes to download.