[gentoo-catalyst] Re: [PATCH] targets: Don't delete pyc/pyo files

[Matt Turner]

On Sat, May 16, 2020 at 4:29 PM Matt Turner <mattst88@g.o> wrote:
>
> These files are actually owned by their packages now, and removing them
> can break subsequent builds.
>
> See https://archives.gentoo.org/gentoo-releng-autobuilds/message/a115781f8e7fb4bd5adfb94a7f2e63b4
>
> Signed-off-by: Matt Turner <mattst88@g.o>
> ---
> I'm minimally concerned about the potential for increasing the size of
> the ISO. I'll report back with numbers.
>
>  targets/livecd-stage1/controller.sh | 4 ----
>  targets/livecd-stage2/controller.sh | 2 --
>  targets/stage1/preclean-chroot.sh   | 2 --
>  3 files changed, 8 deletions(-)
>
> diff --git a/targets/livecd-stage1/controller.sh b/targets/livecd-stage1/controller.sh
> index ced2634e..c4572ff9 100755
> --- a/targets/livecd-stage1/controller.sh
> +++ b/targets/livecd-stage1/controller.sh
> @@ -13,9 +13,5 @@ case $1 in
>                         ${clst_shdir}/${clst_target}/chroot.sh
>                 echo "${clst_packages}" > ${clst_chroot_path}/tmp/packages.txt
>                 ;;
> -
> -       clean)
> -               find ${clst_chroot_path}/usr/lib -iname "*.pyc" -exec rm -f {} \;
> -               ;;
>  esac
>  exit $?
> diff --git a/targets/livecd-stage2/controller.sh b/targets/livecd-stage2/controller.sh
> index 8ee46d7c..0701a26b 100755
> --- a/targets/livecd-stage2/controller.sh
> +++ b/targets/livecd-stage2/controller.sh
> @@ -85,8 +85,6 @@ case $1 in
>                 then
>                         # Clean out man, info and doc files
>                         rm -rf ${clst_chroot_path}/usr/share/{man,doc,info}/*
> -                       # Zap all .pyc and .pyo files
> -                       find ${clst_chroot_path}/usr/lib* -iname "*.py[co]" -exec rm -f {} \;

I think we may want to keep this intact for livecd-stage2. The ISO
sizes goes from 286M to 305M.

What do other people think?