| 1 |
On Sat, 2 May 2020 16:18:43 -0700 |
| 2 |
Matt Turner <mattst88@g.o> wrote: |
| 3 |
|
| 4 |
> On Sat, May 2, 2020 at 4:03 PM Brian Dolbec <dolsen@g.o> wrote: |
| 5 |
> > |
| 6 |
> > On Fri, 1 May 2020 18:40:31 -0700 |
| 7 |
> > Matt Turner <mattst88@g.o> wrote: |
| 8 |
> > |
| 9 |
> > > Signed-off-by: Matt Turner <mattst88@g.o> |
| 10 |
> > > --- |
| 11 |
> > |
| 12 |
> > Again, no reasoning |
| 13 |
> |
| 14 |
> Sorry. I think it's pretty apparent. |
| 15 |
> |
| 16 |
> Simple functions that are called only from a single place and exist in |
| 17 |
> a different file should just be inlined. |
| 18 |
> |
| 19 |
> Should I just add that to the commit message? |
| 20 |
> |
| 21 |
|
| 22 |
No, like I commented in patch #6, list what was inlined. Was a poor |
| 23 |
choice of words on my part. |
| 24 |
|
| 25 |
The way your commit message are, you have to have the commits open in |
| 26 |
gitg or gitweb log view, or git log yyyyyyyyy to see the changes to |
| 27 |
know what was changed, or why. |
| 28 |
|
| 29 |
It is about readability. |
| 30 |
|
| 31 |
|
| 32 |
|
| 33 |
eg: |
| 34 |
|
| 35 |
# git log |
| 36 |
... |
| 37 |
commit yyyyyyyyyyyyyyyyyyyyyyyyyyyyy |
| 38 |
Author: Matt Turner <mattst88@g.o> |
| 39 |
Date: Tue Apr 22 17:57:34 2020 -0700 |
| 40 |
|
| 41 |
targets: Inline functions with one caller |
| 42 |
|
| 43 |
commit xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx |
| 44 |
Author: Matt Turner <mattst88@g.o> |
| 45 |
Date: Tue Apr 21 17:57:34 2020 -0700 |
| 46 |
|
| 47 |
targets: Inline filesystem-functions.sh |
| 48 |
|
| 49 |
commit wwwwwwwwwwwwwwwwwwwwwwwwwwwwww |
| 50 |
Author: Matt Turner <mattst88@g.o> |
| 51 |
Date: Tue Apr 21 17:57:34 2020 -0700 |
| 52 |
|
| 53 |
targets: Drop most fstypes |
| 54 |
|
| 55 |
================================================================== |
| 56 |
Better is |
| 57 |
================================================================== |
| 58 |
|
| 59 |
commit yyyyyyyyyyyyyyyyyyyyyyyyyyyyy |
| 60 |
Author: Matt Turner <mattst88@g.o> |
| 61 |
Date: Tue Apr 22 17:57:34 2020 -0700 |
| 62 |
|
| 63 |
targets: Inline functions with one caller |
| 64 |
|
| 65 |
check_bootargs, check_filesystem_type were only |
| 66 |
used in bootloader_setup.sh |
| 67 |
|
| 68 |
|
| 69 |
commit xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx |
| 70 |
Author: Matt Turner <mattst88@g.o> |
| 71 |
Date: Tue Apr 21 17:57:34 2020 -0700 |
| 72 |
|
| 73 |
targets: Inline filesystem-functions.sh |
| 74 |
|
| 75 |
create_squashfs, create_jffs2 were only used in |
| 76 |
target_image_setup.sh |
| 77 |
|
| 78 |
commit wwwwwwwwwwwwwwwwwwwwwwwwwwwwww |
| 79 |
Author: Matt Turner <mattst88@g.o> |
| 80 |
Date: Tue Apr 21 17:57:34 2020 -0700 |
| 81 |
|
| 82 |
targets: Drop most fstypes |
| 83 |
|
| 84 |
drop ziofs, normal, noloop filesystem types |
| 85 |
They are old/obsolete/ no longer relavent... |
Archives